Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-15443: [enterprise-4.13] Issue in file installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc #63610

Merged
merged 2 commits into from Aug 17, 2023
Merged

OCPBUGS-15443: [enterprise-4.13] Issue in file installing/installing_bare_metal_ipi/ipi-install-installation-workflow.adoc #63610

merged 2 commits into from Aug 17, 2023

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Aug 15, 2023 •
edited

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://184.23.213.161:8080/OCPBUGS-15443/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14, 4.13, 4.12, 4.11, 4.10
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

@johnwilkins
Added a load balancing discussion to the overview.
1b23a1d 
Signed-off-by: John Wilkins <jowilkin@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 15, 2023
@openshift-ci-robot
Copy link

@johnwilkins: This pull request references Jira Issue OCPBUGS-15443, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://jowilkin.com:8080/OCPBUGS-15443/welcome/index.html

For release(s): 4.14, 4.13
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2023
@openshift-ci-robot
Copy link

@johnwilkins: This pull request references Jira Issue OCPBUGS-15443, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://184.23.213.161:8080/OCPBUGS-15443/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14, 4.13
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnwilkins
Copy link
Contributor Author

@cybertron Can you have a look at this? I just put a brief description of the API VIP and load balancing as part of the overview page, because there really isn't any configuration work for anyone to do. So it's really not a procedure.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 15, 2023 •
edited

🤖 Updated build preview is available at:
https://63610--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/22195

cybertron
cybertron reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@cybertron cybertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, but otherwise lgtm.

installing/installing_bare_metal_ipi/ipi-install-overview.adoc Outdated Show resolved Hide resolved
@johnwilkins
Incorporated feedback and removed reference to systemd.
570704b 
Signed-off-by: John Wilkins <jowilkin@redhat.com>
@johnwilkins
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 16, 2023
@openshift-ci-robot
Copy link

@johnwilkins: This pull request references Jira Issue OCPBUGS-15443, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://184.23.213.161:8080/OCPBUGS-15443/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14, 4.13, 4.12, 4.11, 4.10
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@johnwilkins: This pull request references Jira Issue OCPBUGS-15443, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://184.23.213.161:8080/OCPBUGS-15443/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14, 4.13, 4.12, 4.11, 4.10
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnwilkins
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 16, 2023
@openshift-ci-robot
Copy link

@johnwilkins: This pull request references Jira Issue OCPBUGS-15443, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Member

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 17, 2023
skrthomas
skrthomas approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 17, 2023
@johnwilkins
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 17, 2023
@skrthomas skrthomas removed the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 17, 2023
@skrthomas skrthomas added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Aug 17, 2023
@skrthomas skrthomas merged commit d438ff2 into openshift:main Aug 17, 2023
1 check passed
@openshift-ci-robot
Copy link

@johnwilkins: Jira Issue OCPBUGS-15443: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15443 has been moved to the MODIFIED state.

In response to this:

Added a discussion of load balancing to the overview.

Fixes: OCPBUGS-15443

See https://issues.redhat.com/browse/OCPBUGS-15443 for additional details.

Preview URL: http://184.23.213.161:8080/OCPBUGS-15443/installing/installing_bare_metal_ipi/ipi-install-overview.html

For release(s): 4.14, 4.13, 4.12, 4.11, 4.10
QE Review:

  • QE has approved this change.

Signed-off-by: John Wilkins jowilkin@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas added this to the Continuous Release milestone Aug 17, 2023
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.10

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.11

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #63714

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #63716

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #63718

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #63719

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #63720

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cybertron cybertron cybertron left review comments

@skrthomas skrthomas skrthomas approved these changes

Assignees

@cybertron cybertron

@skrthomas skrthomas

Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@johnwilkins @openshift-ci-robot @ocpdocs-previewbot @cybertron @skrthomas @openshift-cherrypick-robot