Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rel Notes for Storage 4.14 #63632

Merged
merged 1 commit into from Oct 19, 2023
Merged

Rel Notes for Storage 4.14 #63632

merged 1 commit into from Oct 19, 2023

Conversation

lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Aug 16, 2023 •
edited

Version(s): 4.14 only

Issue: release note 4.14 storage changes

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

PTAL: @dobsonj, @tsmetana, @gnufied, @jsafrane, @bertinatto, @gcharot, @ropatil010, @chao007, @radeore, @duanwei33

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2023
@lpettyjo lpettyjo added this to the Planned for 4.14 GA milestone Aug 16, 2023
@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 16, 2023
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 16, 2023
skrthomas
skrthomas reviewed Aug 16, 2023
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments and wondering about missing links. I guess once the linked docs are merged, this build won't be broken?

release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Aug 16, 2023
@lpettyjo lpettyjo force-pushed the rel_notes_4_14 branch 3 times, most recently from 39ce1ac to 169a5c8 Compare August 17, 2023 16:12
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 17, 2023 •
edited

🤖 Updated build preview is available at:
https://63632--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28916

@lpettyjo lpettyjo requested a review from gnufied August 17, 2023 19:09
@duanwei33
Copy link

duanwei33 commented Aug 22, 2023 •
edited

Is it worth mentioning Azure File / Azure Disk support for managed identities?
If it is mentioned in installer part, I think it's okay to omit it here.
@lpettyjo @RomanBednar

@duanwei33
Copy link

duanwei33 commented Aug 22, 2023 •
edited

In "Deprecated and removed features" section
"vSphere 7.0 Update 1 or earlier" should be "Deprecated"(instead of "General Availability") in 4.12. I believe it belongs to installer part, so I leave comments in their jira.
@lpettyjo

@lpettyjo lpettyjo force-pushed the rel_notes_4_14 branch 2 times, most recently from cff612a to 7d05e41 Compare August 24, 2023 13:40
@lpettyjo
Copy link
Contributor Author

vSphere 7.0 Update 1 or earlier

@duanwei33 I've corrected this.

@lpettyjo
Copy link
Contributor Author

lpettyjo commented Sep 14, 2023 •
edited

Need to add known bug for NFS Azure File support. https://issues.redhat.com/browse/OCPBUGS-18581

@lpettyjo lpettyjo force-pushed the rel_notes_4_14 branch 3 times, most recently from 075ad02 to 677fb82 Compare September 26, 2023 18:46
@dobsonj
Copy link
Member

dobsonj commented Oct 2, 2023

lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2023
@jsafrane
Copy link
Contributor

jsafrane commented Oct 3, 2023

lgtm

@tsmetana
Copy link
Member

tsmetana commented Oct 9, 2023

lgtm (CSI Filestore GA)

@gnufied
Copy link
Member

gnufied commented Oct 9, 2023

lgtm

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@bertinatto
Copy link
Member

lgtm

@duanwei33
Copy link

@lpettyjo Hi, did you add the azure-file-nfs known issue OCPBUGS-18581 somewhere?

@lpettyjo lpettyjo force-pushed the rel_notes_4_14 branch 3 times, most recently from a53c7a1 to 5e9f79a Compare October 12, 2023 17:11
bergerhoffer
bergerhoffer reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpettyjo I added a suggestion for the link to my section. My secrets store PR merged, so if you rebase you should get the updates and be able to check that the xref I gave actually works.

release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Show resolved Hide resolved
@lpettyjo
Copy link
Contributor Author

@lpettyjo Hi, did you add the azure-file-nfs known issue OCPBUGS-18581 somewhere?

@duanwei33 It's not directly in these changes, but I've updated the JIRA card with the RN text and marked it for inclusion when all of the bugs are added.

@gcharot
Copy link

gcharot commented Oct 16, 2023

lgtm

@ropatil010
Copy link

LGTM, Thanks..!

@chao007
Copy link

chao007 commented Oct 17, 2023

lgtm

@radeore
Copy link

radeore commented Oct 18, 2023

LGTM

@duanwei33
Copy link

LGTM

@bergerhoffer
Copy link
Contributor

Line for linking to my docs for the secrets store operator LGTM 👍

@lpettyjo lpettyjo merged commit 0a2b0aa into openshift:enterprise-4.14 Oct 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcharot gcharot gcharot left review comments

@bergerhoffer bergerhoffer bergerhoffer left review comments

@skrthomas skrthomas skrthomas left review comments

@radeore radeore radeore left review comments

@gnufied gnufied Awaiting requested review from gnufied

Assignees
No one assigned
Labels
branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.14 GA
Development

Successfully merging this pull request may close these issues.

None yet