Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-2039: FIO 1.3.1 release notes #63648

Merged
merged 1 commit into from Aug 21, 2023
Merged

Conversation

sheriff-rh
Copy link
Contributor

@sheriff-rh sheriff-rh commented Aug 16, 2023

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview (VPN required):
OpenShift File Integrity Operator 1.3.1

QE review:

  • QE has approved this change.

Additional information:
This is a clone of #61261 so I can make final adjustments prior to the release on Monday. Adding QE approval and peer-review-done labels applied in the previous PR.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@sheriff-rh: This pull request references CMP-2039 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview:
In progress

QE review:

  • QE has approved this change.

Additional information:
In progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 16, 2023
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@sheriff-rh: This pull request references CMP-2039 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview (VPN required):
OpenShift File Integrity Operator 1.3.1

QE review:

  • QE has approved this change.

Additional information:
In progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@sheriff-rh: This pull request references CMP-2039 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview (VPN required):
OpenShift File Integrity Operator 1.3.1

QE review:

  • QE has approved this change.

Additional information:
This is a clone of #61261 so I can make final adjustments prior to the release on Monday.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@sheriff-rh: This pull request references CMP-2039 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview (VPN required):
OpenShift File Integrity Operator 1.3.1

QE review:

  • QE has approved this change.

Additional information:
This is a clone of #61261 so I can make final adjustments prior to the release on Monday. Adding QE approval and peer-review-done labels applied in the previous PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2023

@sheriff-rh: This pull request references CMP-2039 which is a valid jira issue.

In response to this:

Version(s):
4.10+

Issue:
https://issues.redhat.com/browse/CMP-2039

Link to docs preview (VPN required):
OpenShift File Integrity Operator 1.3.1

QE review:

  • QE has approved this change.

Additional information:
This is a clone of #61261 so I can make final adjustments prior to the release on Monday. Adding QE approval and peer-review-done labels applied in the previous PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sheriff-rh sheriff-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 16, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 16, 2023

🤖 Updated build preview is available at:
https://63648--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/22365

[id="file-integrity-operator-1-3-1-bug-fixes"]
=== Bug fixes

* Previously, FIO would not clean up `FileIntegrityNodeStatus` CRDs when nodes are removed from the cluster. FIO would also erroneously indicate that new nodes failed integrity checks. FIO has been updated to correctly clean up node status CRDs on node removal or when adding new nodes to the cluster. This provides correct node status notifications. (link:https://issues.redhat.com/browse/OCPBUGS-8502[*OCPBUGS-8502*])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor issue, do we need to add link for https://issues.redhat.com/browse/OCPBUGS-4231?
https://issues.redhat.com/browse/OCPBUGS-4231 is for cleanup FileIntegrityNodeStatus CRDs issue;
https://issues.redhat.com/browse/OCPBUGS-8502. is for new adding nodes issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaojiey I'll change it to OCPBUGS-4231.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seems I didn't make it clearly. I mean actually it addressed two bugs, https://issues.redhat.com/browse/OCPBUGS-4231 and https://issues.redhat.com/browse/OCPBUGS-8502. Can we adding both links or split it into two parts directly (like below)? Thanks.

Previously, FIO would not clean up `FileIntegrityNodeStatus` CRDs when nodes are removed from the cluster. FIO has been updated to correctly clean up node status CRDs on node removal.  (link:https://issues.redhat.com/browse/OCPBUGS-4321[*OCPBUGS-4321*])
Previously, FIO would also erroneously indicate that new nodes failed integrity checks. FIO has been updated to correctly show node status CRDs when adding new nodes to the cluster. This provides correct node status notifications. (link:https://issues.redhat.com/browse/OCPBUGS-8502[*OCPBUGS-8502*])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xiaojiey ! I have made the changes.

@xiaojiey
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 21, 2023
@sheriff-rh
Copy link
Contributor Author

Merging.

@sheriff-rh sheriff-rh merged commit 8d82f10 into openshift:main Aug 21, 2023
1 check passed
@sheriff-rh
Copy link
Contributor Author

/cherrypick enterprise-4.14

@sheriff-rh
Copy link
Contributor Author

/cherrypick enterprise-4.13

@sheriff-rh
Copy link
Contributor Author

/cherrypick enterprise-4.12

@sheriff-rh
Copy link
Contributor Author

/cherrypick enterprise-4.11

@sheriff-rh
Copy link
Contributor Author

/cherrypick enterprise-4.10

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #63744

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #63745

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #63746

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #63748

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@sheriff-rh: new pull request created: #63749

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants