Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-433: fix-wrong-annotation-for-thanosrulerconfig-4.12 #63825

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Aug 22, 2023

Version(s): 4.12 only

Issue: https://issues.redhat.com/browse/OBSDOCS-433

Link to docs preview: https://63825--docspreview.netlify.app/openshift-enterprise/latest/monitoring/config-map-reference-for-the-cluster-monitoring-operator#description-15

QE review: @juzhao

  • QE has approved this change.

Additional information: Fixes an error in the ThanosRulerConfig info in the CMO config reference for OCP 4.12. Also removes some extraneous trailing spaces.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 22, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2023

@bburt-rh: This pull request references OBSDOCS-433 which is a valid jira issue.

In response to this:

Version(s): 4.12 only

Issue: https://issues.redhat.com/browse/OBSDOCS-433

Link to docs preview:

QE review: @juzhao

  • QE has approved this change.

Additional information: Fixes an error in the ThanosRulerConfig info in the CMO config reference for 4.12.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh requested a review from juzhao August 22, 2023 19:09
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 22, 2023
@openshift openshift deleted a comment from openshift-ci-robot Aug 22, 2023
@openshift openshift deleted a comment from openshift-ci-robot Aug 22, 2023
@bburt-rh bburt-rh added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.12 labels Aug 22, 2023
@ocpdocs-previewbot
Copy link

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2023

@bburt-rh: This pull request references OBSDOCS-433 which is a valid jira issue.

In response to this:

Version(s): 4.12 only

Issue: https://issues.redhat.com/browse/OBSDOCS-433

Link to docs preview: https://63825--docspreview.netlify.app/openshift-enterprise/latest/monitoring/config-map-reference-for-the-cluster-monitoring-operator#description-15

QE review: @juzhao

  • QE has approved this change.

Additional information: Fixes an error in the ThanosRulerConfig info in the CMO config reference for OCP 4.12. Also removes some extraneous trailing spaces.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juzhao
Copy link

juzhao commented Aug 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@bburt-rh bburt-rh added the qe-approved Signifies that QE has signed off on this PR label Aug 23, 2023
@openshift openshift deleted a comment from openshift-ci-robot Aug 23, 2023
@bburt-rh bburt-rh added this to the Continuous Release milestone Aug 23, 2023
@bburt-rh bburt-rh added the peer-review-done Signifies that the peer review team has reviewed this PR label Aug 24, 2023
@bburt-rh bburt-rh merged commit 8f05c9e into openshift:enterprise-4.12 Aug 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants