Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP 2164 rephrase #63978

Merged
merged 1 commit into from
Aug 30, 2023
Merged

OADP 2164 rephrase #63978

merged 1 commit into from
Aug 30, 2023

Conversation

CarmiWisemon
Copy link
Contributor

@CarmiWisemon CarmiWisemon commented Aug 28, 2023

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 28, 2023

🤖 Updated build preview is available at:
https://63978--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/23158

Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CarmiWisemon
Copy link
Contributor Author

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 28, 2023
@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 28, 2023
@@ -21,7 +21,7 @@ You must exclude Operators from the backup of an application for backup and rest


Restore::
You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the restored objects by namespace, PV, or label.
You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the objects to be restored by namespace, PV, or label.
Copy link
Contributor

@dfitzmau dfitzmau Aug 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the "to be restored" passive construct? I think "You can restore" covers the restoration operation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the objects by namespace, PV, or label.

@stillalearner Is this phrasing OK with you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau
Thank you. I updated it based on your suggestion.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarmiWisemon Looks good.

@CarmiWisemon
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 30, 2023
@mburke5678 mburke5678 added branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Aug 30, 2023
@mburke5678 mburke5678 added this to the Continuous Release milestone Aug 30, 2023
@mburke5678 mburke5678 merged commit 5be673f into openshift:main Aug 30, 2023
1 check passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@mburke5678: new pull request created: #64097

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.11 from head openshift-cherrypick-robot:cherry-pick-63978-to-enterprise-4.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-63978-to-enterprise-4.11."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@mburke5678: new pull request created: #64099

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #64100

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #64101

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants