-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OADP 2164 rephrase #63978
OADP 2164 rephrase #63978
Conversation
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/23158 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/label OADP |
d1bc29a
to
8bac026
Compare
/remove-label peer-review-needed /label peer-review-in-progress |
modules/oadp-features.adoc
Outdated
@@ -21,7 +21,7 @@ You must exclude Operators from the backup of an application for backup and rest | |||
|
|||
|
|||
Restore:: | |||
You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the restored objects by namespace, PV, or label. | |||
You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the objects to be restored by namespace, PV, or label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the "to be restored" passive construct? I think "You can restore" covers the restoration operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can restore resources and PVs from a backup. You can restore all objects in a backup or filter the objects by namespace, PV, or label.
@stillalearner Is this phrasing OK with you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dfitzmau
Thank you. I updated it based on your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarmiWisemon Looks good.
c9077a0
to
fb56087
Compare
fb56087
to
a0cd5ea
Compare
/label merge-review-needed |
/cherrypick enterprise-4.11 |
@mburke5678: new pull request created: #64097 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.12 |
@mburke5678: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.11 from head openshift-cherrypick-robot:cherry-pick-63978-to-enterprise-4.11: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-63978-to-enterprise-4.11."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
@mburke5678: new pull request created: #64099 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mburke5678: new pull request created: #64100 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mburke5678: new pull request created: #64101 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP - 1.1.6
OADP - 1.2.1
OCP - 4.11+
Resolves - https://issues.redhat.com/browse/OADP-2164
Preview - https://63978--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/oadp-features-plugins