Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitOps 1.8.5 release notes documentation. #64187

Merged
merged 1 commit into from
Sep 12, 2023
Merged

GitOps 1.8.5 release notes documentation. #64187

merged 1 commit into from
Sep 12, 2023

Conversation

masauso-lungu
Copy link
Contributor

@masauso-lungu masauso-lungu commented Aug 31, 2023 •
edited

Jira issue : RHDEVDOCS-5612

Aligned team: DevTools
OCP Version(s): 4.10, 4.11, 4.12 and to 4.13

Docs preview: GitOps-RN-1.8.5

SME review: @reginapizza

QE review: @varshab1210

Peer review: @Srivaralakshmi

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 31, 2023 •
edited

🤖 Updated build preview is available at:
https://64187--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/24403

@masauso-lungu masauso-lungu force-pushed the ml-gitops-RN_1-8-5 branch 2 times, most recently from 72f0571 to 69fb81c Compare September 1, 2023 09:03
@masauso-lungu masauso-lungu marked this pull request as ready for review September 1, 2023 09:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2023
@Srivaralakshmi
Copy link
Member

@@iam-veeramalla Please confirm - are we adding this errata v1.8.5 - https://errata.engineering.redhat.com/advisory/120046 to the Release Notes?

@masauso-lungu If yes, then please add it and ping me for the peer review.

Thanks!

@Srivaralakshmi
Copy link
Member

@masauso-lungu Please edit the PR title for the typo.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 7, 2023
@masauso-lungu masauso-lungu changed the title GitOps 1.8.5 release notes documantion. GitOps 1.8.5 release notes documentation. Sep 7, 2023
Srivaralakshmi
Srivaralakshmi requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masauso-lungu Please remember to notice the change in the RHSA number if any for this advisory once the errata state is changed to SHIPPED LIVE.

Otherwise, LGTM

modules/gitops-release-notes-1-8-5.adoc Outdated Show resolved Hide resolved
@masauso-lungu masauso-lungu force-pushed the ml-gitops-RN_1-8-5 branch 2 times, most recently from 42eeccf to 12fe9cc Compare September 8, 2023 12:57
@reginapizza
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
Srivaralakshmi
Srivaralakshmi requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masauso-lunguThanks for the great work! one minor change is required.

cicd/gitops/gitops-release-notes.adoc Show resolved Hide resolved
modules/gitops-release-notes-1-8-5.adoc Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@masauso-lungu
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 8, 2023
@Srivaralakshmi
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@varshab1210
Copy link

/lgtm

@masauso-lungu
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 11, 2023
@masauso-lungu
GitOps 1.8.5 release notes documantion.
c3ba9ff 
Added content to the draft doc.

Miner update for doc refinement.

Added Errata updates.

Updated the errata links.

Miner update to address peer review.

Miner fix for doc consistency.

Update to address QE review.

miner update to address merge review.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 12, 2023

New changes are detected. LGTM label has been removed.

@masauso-lungu
Copy link
Contributor Author

/label merge-review-needed

@bscott-rh bscott-rh added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 12, 2023
@bscott-rh bscott-rh added this to the Continuous Release milestone Sep 12, 2023
@bscott-rh bscott-rh merged commit d3bd2b0 into openshift:main Sep 12, 2023
1 check passed
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot
Copy link

@bscott-rh: #64187 failed to apply on top of branch "enterprise-4.11":

Applying: GitOps 1.8.5 release notes documantion.
.git/rebase-apply/patch:55: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	cicd/gitops/gitops-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging cicd/gitops/gitops-release-notes.adoc
CONFLICT (content): Merge conflict in cicd/gitops/gitops-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 GitOps 1.8.5 release notes documantion.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2023
Merged
@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #64635

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

@bscott-rh: new pull request created: #64636

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2023
Merged
@bscott-rh
Copy link
Contributor

As of September 10, 4.10 is EOL and not receiving any documentation updates. The 4.11 cherrypick failed and will need to be resolved manually, and 4.12 and 4.13 have been merged.

@masauso-lungu masauso-lungu mentioned this pull request Sep 13, 2023
Merged
@masauso-lungu masauso-lungu deleted the ml-gitops-RN_1-8-5 branch October 18, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iam-veeramalla iam-veeramalla iam-veeramalla left review comments

@reginapizza reginapizza reginapizza left review comments

@varshab1210 varshab1210 varshab1210 left review comments

@bscott-rh bscott-rh bscott-rh left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

Assignees

@reginapizza reginapizza

@varshab1210 varshab1210

@Srivaralakshmi Srivaralakshmi

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@masauso-lungu @ocpdocs-previewbot @Srivaralakshmi @reginapizza @varshab1210 @bscott-rh @openshift-cherrypick-robot @iam-veeramalla