Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] OBSDOCS-475 - Logging 5.7.6 Release Notes #64615

Merged
merged 1 commit into from Sep 13, 2023
Merged

[DOCS] OBSDOCS-475 - Logging 5.7.6 Release Notes #64615

merged 1 commit into from Sep 13, 2023

Conversation

shreyasiddhartha
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha commented Sep 12, 2023 •
edited

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 12, 2023 •
edited

🤖 Updated build preview is available at:
https://64615--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/24538

@kabirbhartiRH
Copy link

I think we need to add below bugs as well.
https://issues.redhat.com/browse/LOG-4171
https://issues.redhat.com/browse/LOG-4393
https://issues.redhat.com/browse/LOG-4467

@shreyasiddhartha
Copy link
Contributor Author

@kabirbhartiRH I think we only document "public" bugs available in the errata and not the "private" ones.
@libander any comments on this?

@kabirbhartiRH
Copy link

kabirbhartiRH commented Sep 13, 2023 •
edited by openshift-ci bot

@kabirbhartiRH I think we only document "public" bugs available in the errata and not the "private" ones. @libander any comments on this?

I went back and checked for Logging 5.7.4 https://errata.devel.redhat.com/advisory/117246
It seems we have included such bugs in Docs. AFAIK, we don't include NEC restricted bugs in docs but may include those which are RH employee/contractor restricted.

for e.g. #62992, LOG-3381 is included but other restricted bugs are not (NEC one's)

@shreyasiddhartha
Copy link
Contributor Author

@kabirbhartiRH I think we only document "public" bugs available in the errata and not the "private" ones. @libander any comments on this?

I went back and checked for Logging 5.7.4 https://errata.devel.redhat.com/advisory/117246 It seems we have included such bugs in Docs. AFAIK, we don't include NEC restricted bugs in docs but may include those which are RH employee/contractor restricted.

for e.g. #62992, LOG-3381 is included but other restricted bugs are not (NEC one's)

@kabirbhartiRH Thanks for clarifying. I have included the bugs. PTAL. :)

@briandooley
Copy link
Contributor

briandooley commented Sep 13, 2023 •
edited

Release notes text in LOG-4456 was found to be out of date during QE review. It has been changed and we are currently altering the PR with the new information.

@kabirbhartiRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
xperimental
xperimental reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some small changes.

modules/logging-rn-5.7.6.adoc Outdated Show resolved Hide resolved
modules/logging-rn-5.7.6.adoc Show resolved Hide resolved
modules/logging-rn-5.7.6.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

New changes are detected. LGTM label has been removed.

@shreyasiddhartha
Copy link
Contributor Author

@xperimental I have made the changes suggested by you. PTAL and give LGTM if it's okay. Thanks! :)

@shreyasiddhartha shreyasiddhartha changed the title [WIP] OBSDOCS-475 - Logging 5.7.6 Release Notes [DOCS] OBSDOCS-475 - Logging 5.7.6 Release Notes Sep 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
briandooley
briandooley reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@briandooley briandooley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minors grammar comments.

modules/logging-rn-5.7.6.adoc Outdated Show resolved Hide resolved
modules/logging-rn-5.7.6.adoc Outdated Show resolved Hide resolved
modules/logging-rn-5.7.6.adoc Outdated Show resolved Hide resolved
@shreyasiddhartha
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 13, 2023
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 13, 2023
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Sep 13, 2023
@kcarmichael08 kcarmichael08 merged commit e94b1d9 into openshift:main Sep 13, 2023
1 check passed
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.11

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.12

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.13

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #64695

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 13, 2023
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #64696

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 13, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #64697

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #64698

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandooley briandooley briandooley left review comments

@libander libander libander left review comments

@xperimental xperimental xperimental approved these changes

Assignees

@kabirbhartiRH kabirbhartiRH

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@shreyasiddhartha @ocpdocs-previewbot @kabirbhartiRH @briandooley @kcarmichael08 @openshift-cherrypick-robot @xperimental @libander