Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-310: Monitoring-4.14-RN-new-features #64732

Merged
merged 1 commit into from Sep 22, 2023
Merged

OBSDOCS-310: Monitoring-4.14-RN-new-features #64732

merged 1 commit into from Sep 22, 2023

Conversation

bburt-rh
Copy link
Contributor

@bburt-rh bburt-rh commented Sep 14, 2023 •
edited

Version(s): 4.14 only

Issue: https://issues.redhat.com/browse/OBSDOCS-310

Direct link to docs preview:

QE review: @juzhao @Tai-RedHat

  • QE has approved this change.

Additional information:

  • Adds new monitoring feature descriptions to the 4.14 release notes.
  • Updates monitoring Tech Preview table to indicate that creating/modifying alerts feature is going GA with 4.14.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-310 which is a valid jira issue.

In response to this:

Version(s): 4.14 only

Issue: https://issues.redhat.com/browse/OBSDOCS-310

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information: Adds new monitoring feature descriptions to the 4.14 release notes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 14, 2023 •
edited

🤖 Updated build preview is available at:
https://64732--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/25639

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 14, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-310 which is a valid jira issue.

In response to this:

Version(s): 4.14 only

Issue: https://issues.redhat.com/browse/OBSDOCS-310

Direct link to docs preview: https://64732--docspreview.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-14-release-notes#ocp-4-14-monitoring

QE review: @juzhao

  • QE has approved this change.

Additional information: Adds new monitoring feature descriptions to the 4.14 release notes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch 4 times, most recently from f0f5df6 to a48275f Compare September 14, 2023 15:38
@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from a48275f to ce11aef Compare September 15, 2023 13:55
@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from ce11aef to 9282aa1 Compare September 18, 2023 14:37
@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from 9282aa1 to b493652 Compare September 19, 2023 12:42
kelbrown20
kelbrown20 reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@kelbrown20 kelbrown20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Just a couple suggestions and nits that are up to you! Great work!

release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Show resolved Hide resolved
release_notes/ocp-4-14-release-notes.adoc Outdated Show resolved Hide resolved
@kelbrown20 kelbrown20 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 19, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-310 which is a valid jira issue.

In response to this:

Version(s): 4.14 only

Issue: https://issues.redhat.com/browse/OBSDOCS-310

Direct link to docs preview:

QE review: @juzhao @Tai-RedHat

  • QE has approved this change.

Additional information:

  • Adds new monitoring feature descriptions to the 4.14 release notes.
  • Updates monitoring Tech Preview table to indicate that creating/modifying alerts feature is going GA with 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from 582fed3 to b85dd8e Compare September 19, 2023 16:40
@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch 2 times, most recently from e4f15b6 to 0ec9b98 Compare September 20, 2023 13:12
jan--f
jan--f approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@juzhao
Copy link

juzhao commented Sep 21, 2023

/lgtm

@juzhao
Copy link

juzhao commented Sep 21, 2023 •
edited

@raptorsun
#64732 (comment)
I think we need to mention gomaxprocs although it's not a collector, not just remove it from doc, WDYT?

@raptorsun
Copy link

@raptorsun #64732 (comment) I think we need to mention gomaxprocs although it's not a collector, not just remove it from doc, WDYT?

yes, let's mention the gomaxprocs option at line 375.

@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from 0ec9b98 to d2edf3b Compare September 21, 2023 13:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2023

New changes are detected. LGTM label has been removed.

@bburt-rh
Copy link
Contributor Author

@raptorsun #64732 (comment) I think we need to mention gomaxprocs although it's not a collector, not just remove it from doc, WDYT?

yes, let's mention the gomaxprocs option at line 375.

@raptorsun and @juzhao - I added a line about gomaxprocs. PTAL and let me know if any changes are needed.

@bburt-rh bburt-rh force-pushed the OBSDOCS-310-monitoring-4.14-RN-new-features branch from d2edf3b to 2a00f80 Compare September 22, 2023 17:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2023 •
edited by openshift-ci bot

@bburt-rh: This pull request references OBSDOCS-310 which is a valid jira issue.

In response to this:

Version(s): 4.14 only

Issue: https://issues.redhat.com/browse/OBSDOCS-310

Direct link to docs preview:

QE review: @juzhao @Tai-RedHat

  • QE has approved this change.

Additional information:

  • Adds new monitoring feature descriptions to the 4.14 release notes.
  • Updates monitoring Tech Preview table to indicate that creating/modifying alerts feature is going GA with 4.14.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bburt-rh bburt-rh added the qe-approved Signifies that QE has signed off on this PR label Sep 22, 2023
@bburt-rh bburt-rh merged commit 623d4b1 into openshift:enterprise-4.14 Sep 22, 2023
1 check passed
@juzhao
Copy link

juzhao commented Sep 25, 2023

/lgtm

@bburt-rh bburt-rh mentioned this pull request Oct 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha left review comments

@juzhao juzhao juzhao left review comments

@kelbrown20 kelbrown20 kelbrown20 left review comments

@Tai-RedHat Tai-RedHat Tai-RedHat left review comments

@jan--f jan--f jan--f approved these changes

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@jan--f jan--f

@juzhao juzhao

Labels
branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.14 GA
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bburt-rh @openshift-ci-robot @ocpdocs-previewbot @juzhao @raptorsun @jan--f @sthaha @kelbrown20 @Tai-RedHat