OCPBUGS-19403: updates etcd procedure with OVN-K i/c

[JoeAldinger]

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19403

Link to docs preview:
https://64939--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state#:~:text=If%20you%20are%20using%20the%20OVNKubernetes%20network%20plugin%2C%20you%20must%20restart%20ovnkube%2Dcontrolplane%20pods.

QE review:

• QE has approved this change.

Additional information:
PTAL: @geliu2016
Looking for another review since I changed so much based on excellent feedback.

[openshift-ci-robot]

@JoeAldinger: This pull request references Jira Issue OCPBUGS-19403, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ocpdocs-previewbot]

🤖 Updated build preview is available at:
https://64939--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/26118

[palonsoro]

@JoeAldinger please wherever it says $<node> please use <node>. It is me (again) using the bash-like syntax, while the docs better benefit from the <whatever> syntax.

In new step 13.d, I'd warn that it may take long for the pod to be ready (up to several minutes). Users may get nervous otherwise.

For the rest, it looks perfect to me. Many thanks! Also looking forward for the QE testing, just to be sure that this doesn't break under scenarios I might have not considered.

[palonsoro]

It now looks better 🙂

[geliu2016]

/lgtm

[openshift-ci-robot]

@JoeAldinger: This pull request references Jira Issue OCPBUGS-19403, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19403

Link to docs preview:
https://64939--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state#:~:text=If%20you%20are%20using%20the%20OVNKubernetes%20network%20plugin%2C%20you%20must%20restart%20ovnkube%2Dcontrolplane%20pods.

QE review:

• QE has approved this change.

Additional information:
PTAL: @geliu2016

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bergerhoffer]

/label peer-review-in-progress

[bergerhoffer]

A few suggestions!

[palonsoro]

@JoeAldinger re-posting here because, for some reason, when I write on reviews, github sometimes doesn't forward my comments:

Re-reading, I saw that you deleted the following paragraphs

Validating and mutating admission webhooks can reject pods. If you add any additional webhooks with the `failurePolicy` set to `Fail`, then they can reject pods and the restoration process can fail. You can avoid this by saving and deleting webhooks while restoring the cluster state. After the cluster state is restored successfully, you can enable the webhooks again.

and

Alternatively, you can temporarily set the `failurePolicy` to `Ignore` while restoring the cluster state. After the cluster state is restored successfully, you can set the `failurePolicy` to `Fail`.

Please don't delete them. They are the solution for a previous bug, so it would be a regression.

Sorry that I didn't notice before.

[palonsoro]

As said in the review, in case the comment doesn't make it: command at newer line 295 should be "delete", not "get".

[palonsoro]

/lgtm

[kowen-rh]

/remove-label peer-review-needed
/label peer-review-in-progress

[kowen-rh]

A few minor nitpicks, but overall this looks good to me!

/remove-label peer-review-in-progress
/label peer-review-done

[geliu2016]

/lgtm

[openshift-ci-robot]

@JoeAldinger: Jira Issue OCPBUGS-19403 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19403

Link to docs preview:
https://64939--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/disaster_recovery/scenario-2-restoring-cluster-state#:~:text=If%20you%20are%20using%20the%20OVNKubernetes%20network%20plugin%2C%20you%20must%20restart%20ovnkube%2Dcontrolplane%20pods.

QE review:

• QE has approved this change.

Additional information:
PTAL: @geliu2016
Looking for another review since I changed so much based on excellent feedback.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoeAldinger]

/cherrypick enterprise-4.14

[openshift-cherrypick-robot]

@JoeAldinger: new pull request created: #65367

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.