document secretrefs for build webhook triggers #6552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
5 tasks
wzheng1
reviewed
Dec 4, 2017
| name: mysecret | ||
| creationTimestamp: | ||
| data: | ||
| WebHookSecretKey: c2VjcmV0dmFsdWUx |
There was a problem hiding this comment.
it's the base64 encoded value of the webhook secret. just like any k8s secret key/value.
$ base64 -d
c2VjcmV0dmFsdWUx
^D
secretvalue1
|
@openshift/team-documentation ptal, ready for merge. |
bmcelvee
reviewed
Jan 3, 2018
|
|
||
| [source,yaml] | ||
| ---- | ||
| type: "GitHub" | ||
| github: | ||
| secret: "secret101" | ||
| secretRefence: "mysecret" |
There was a problem hiding this comment.
@bparees, should this be: s/secretRefence/secretReference? (all of the following are the same, so I just wanted to check)
Otherwise LGTM!
There was a problem hiding this comment.
yes, should be. fixed, thanks!
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Jan 3, 2018
(cherry picked from commit e6e55d4) xref:openshift#6552
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Jan 3, 2018
(cherry picked from commit e6e55d4) xref:openshift#6552
bmcelvee
pushed a commit
to bmcelvee/openshift-docs
that referenced
this pull request
Jan 3, 2018
(cherry picked from commit e6e55d4) xref:openshift#6552
This was referenced Jan 3, 2018
|
[rev_history] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs for openshift/origin#17314