Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-152: Additional logging docs cleanup #65906

Closed
wants to merge 4 commits into from
Closed

OBSDOCS-152: Additional logging docs cleanup #65906

wants to merge 4 commits into from

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Oct 6, 2023 •
edited

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:

QE review:
Not required. There's no meaningful change to content, just removing unused files and moving existing content.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

@abrennan89 abrennan89 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 labels Oct 6, 2023
@abrennan89 abrennan89 added this to the Continuous Release milestone Oct 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:
TBA

QE review:

  • QE has approved this change.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:
TBA

QE review:

  • QE has approved this change.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:
TBA

QE review:

  • QE has approved this change.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 6, 2023 •
edited

🤖 Updated build preview is available at:
https://65906--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/28363

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2023 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-152 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OBSDOCS-152

Link to docs preview:

QE review:
Not required. There's no meaningful change to content, just removing unused files and moving existing content.

Additional information:

  • Removed unused 5.3 release note files
  • Remove unused topic map entry
  • Remove unnecessary duplicated content (multiple includes for modules)
  • Moved snippet content into main "About" section
  • Updated metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 13, 2023
@nalhadef
Copy link
Contributor

/remove-label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

@nalhadef: Those labels are not set on the issue: peer-review-in-progress

In response to this:

/remove-label peer-review-in-progress
/remove-label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalhadef
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

@nalhadef: Those labels are not set on the issue: peer-review-needed

In response to this:

/label peer-review-in-progress
/remove-label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalhadef
Copy link
Contributor

/lgtm

@nalhadef
Copy link
Contributor

One small comment, Ashleigh.

@nalhadef
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Oct 16, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

New changes are detected. LGTM label has been removed.

@abrennan89 abrennan89 mentioned this pull request Oct 17, 2023
Merged
@abrennan89
Copy link
Contributor Author

There's something weird going on with this PR so I just opened it as a new one instead #66389

@abrennan89 abrennan89 closed this Oct 17, 2023
@abrennan89 abrennan89 deleted the misc-cleanup branch November 13, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalhadef nalhadef nalhadef left review comments

Assignees

@nalhadef nalhadef

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @nalhadef