Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#21817: Updates prereq for customLogoFile size #66695

Merged
merged 1 commit into from
Oct 25, 2023
Merged

OCPBUGS#21817: Updates prereq for customLogoFile size #66695

merged 1 commit into from
Oct 25, 2023

Conversation

opayne1
Copy link
Contributor

@opayne1 opayne1 commented Oct 23, 2023 •
edited

OCPBUGS#21817: Updates prereq for customLogoFile size

Version(s):
4.12, 4.13, & 4.14

Issue:
https://issues.redhat.com/browse/OCPBUGS-21817

Link to docs preview:
https://66695--docspreview.netlify.app/openshift-enterprise/latest/web_console/customizing-the-web-console#adding-a-custom-logo_customizing-web-console

QE review:

  • QE has approved this change.

Additional information:

@opayne1 opayne1 added this to the Continuous Release milestone Oct 23, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 23, 2023 •
edited

🤖 Updated build preview is available at:
https://66695--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/29971

@opayne1
Copy link
Contributor Author

opayne1 commented Oct 23, 2023

Hi @ocasalsa Could you take a look at this PR to update the customLogoFile size? thank you!

@yanpzhan
Copy link

The update LGTM.

@opayne1 opayne1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 24, 2023
@abhatt-rh
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 24, 2023
abhatt-rh
abhatt-rh reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@abhatt-rh abhatt-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @opayne1, Mostly LGTM, just left a comment related to formatting.

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

modules/adding-a-custom-logo.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 24, 2023
@opayne1 opayne1 merged commit a6be8e9 into openshift:main Oct 25, 2023
1 check passed
@opayne1
Copy link
Contributor Author

opayne1 commented Oct 25, 2023

/cherrypick enterprise-4.12

@opayne1
Copy link
Contributor Author

opayne1 commented Oct 25, 2023

/cherrypick enterprise-4.13

@opayne1
Copy link
Contributor Author

opayne1 commented Oct 25, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #66866

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #66867

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@opayne1: new pull request created: #66868

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhatt-rh abhatt-rh abhatt-rh left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@opayne1 @ocpdocs-previewbot @yanpzhan @abhatt-rh @openshift-cherrypick-robot