Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for GitOps 1.9.3 release notes. #67075

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Documentation for GitOps 1.9.3 release notes. #67075

merged 1 commit into from
Nov 20, 2023

Conversation

masauso-lungu
Copy link
Contributor

@masauso-lungu masauso-lungu commented Oct 30, 2023 •
edited

@masauso-lungu masauso-lungu marked this pull request as ready for review October 30, 2023 14:03
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 30, 2023 •
edited

🤖 Updated build preview is available at:
https://67075--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/34029

@kalexand-rh kalexand-rh closed this Nov 6, 2023
@kalexand-rh kalexand-rh reopened this Nov 6, 2023
@varshab1210
Copy link

LGTM, thanks

@masauso-lungu
Copy link
Contributor Author

masauso-lungu commented Nov 9, 2023 •
edited

/label qe-approved

@iam-veeramalla
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@masauso-lungu
Copy link
Contributor Author

/label sme-review-done

@openshift-ci openshift-ci bot added the sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc. label Nov 10, 2023
@masauso-lungu
Copy link
Contributor Author

masauso-lungu commented Nov 10, 2023 •
edited

/label qe-approved

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 10, 2023

@masauso-lungu: The label(s) /label qe-review-done cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label qe-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@masauso-lungu
Copy link
Contributor Author

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR and removed lgtm Indicates that a PR is ready to be merged. labels Nov 10, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 10, 2023

New changes are detected. LGTM label has been removed.

@masauso-lungu
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 10, 2023
@masauso-lungu
Copy link
Contributor Author

Kindly ignore the XXXX placeholders given in the ERRATA link, it will be updated when the product ships live. The purpose of this review is to make sure the PR is merge ready

@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 10, 2023
@lpettyjo lpettyjo self-requested a review November 10, 2023 13:59
lpettyjo
lpettyjo reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM!

modules/gitops-release-notes-1-9-3.adoc Outdated Show resolved Hide resolved
@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 10, 2023
@masauso-lungu
Copy link
Contributor Author

Hello , requesting for a merge review.

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 20, 2023
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 20, 2023
@kcarmichael08
Copy link
Contributor

This looks good to me - is it OK to merge? Just making sure since I'm not familiar with this repo.

@masauso-lungu
Copy link
Contributor Author

Hi @kcarmichael08, Yes you can merge it. the PR is up to date and all reviews have been addressed. thank you.

@kcarmichael08 kcarmichael08 merged commit 1b91d2b into openshift:gitops-docs Nov 20, 2023
1 check passed
@kcarmichael08
Copy link
Contributor

/cherrypick gitops-docs-1.9

@kcarmichael08
Copy link
Contributor

/cherrypick gitops-docs-1.10

@kcarmichael08
Copy link
Contributor

/cherrypick gitops-docs-1.11

@openshift-cherrypick-robot
Copy link

@kcarmichael08: #67075 failed to apply on top of branch "gitops-docs-1.9":

Applying: Documentation for GitOps 1.9.3 release notes.
Using index info to reconstruct a base tree...
M	release_notes/gitops-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging release_notes/gitops-release-notes.adoc
CONFLICT (content): Merge conflict in release_notes/gitops-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Documentation for GitOps 1.9.3 release notes.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #68213

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 20, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #68214

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Nov 21, 2023 •
edited

Hi, we need a manual cherry pick created for gitops-docs-1.9 because the automated cherry pick failed. The cherry picks to other branches were fine.

@masauso-lungu masauso-lungu mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varshab1210 varshab1210 varshab1210 left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@reginapizza reginapizza reginapizza approved these changes

Assignees

@iam-veeramalla iam-veeramalla

Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@masauso-lungu @ocpdocs-previewbot @varshab1210 @iam-veeramalla @kcarmichael08 @openshift-cherrypick-robot @reginapizza @lpettyjo @kalexand-rh