Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for GitOps 1.8.6 release notes #67076

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Documentation for GitOps 1.8.6 release notes #67076

merged 1 commit into from
Nov 8, 2023

Conversation

masauso-lungu
Copy link
Contributor

@masauso-lungu masauso-lungu commented Oct 30, 2023 •
edited

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2023
@masauso-lungu masauso-lungu marked this pull request as ready for review October 30, 2023 14:28
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 30, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 30, 2023 •
edited

🤖 Updated build preview is available at:
https://67076--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/32230

Srivaralakshmi
Srivaralakshmi previously requested changes Nov 2, 2023
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masauso-lungu Thanks for your effort and time. PTAL at the comment and address it. Thank you!

modules/gitops-release-notes-1-8-6.adoc Outdated Show resolved Hide resolved
modules/gitops-release-notes-1-8-6.adoc Outdated Show resolved Hide resolved
@iam-veeramalla
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2023
@masauso-lungu
Copy link
Contributor Author

/label sme-review-done

@openshift-ci openshift-ci bot added the sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc. label Nov 6, 2023
@masauso-lungu
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 6, 2023
@masauso-lungu
Copy link
Contributor Author

NOTE THAT THERE IS CURRENTLY A REVIEW BLOCKER ON THIS PR AS SRI HAD MADE A SUGGESTION, HOWEVER SHE IS OUT SICK TO APPROVE THE CHANGE

@masauso-lungu
Copy link
Contributor Author

masauso-lungu commented Nov 6, 2023 •
edited

[Very important] Please ignore the XXX in the errata link given as it is just a place holder for the actual link which will be made available when the product is shiped live. The intention of getting these reviews is to make sure that the pr is merge ready prior to product release. Thank you.

jeana-redhat
jeana-redhat reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

➡️ Note for merge reviewers ⬅️

At time of peer review, the Live ID is not yet available for the advisory. Before merge, XXXX needs to be replaced with the ID value.

Otherwise, just one suggestion from me, and reminder to squash your commits please 🙂

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

modules/gitops-release-notes-1-8-6.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 6, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 6, 2023

@jeana-redhat: Those labels are not set on the issue: peer-review-in-progress

In response to this:

➡️ Note for merge reviewers ⬅️

At time of peer review, the Live ID is not yet available for the advisory. Before merge, XXXX needs to be replaced with the ID value.

Otherwise, just one suggestion from me, and reminder to squash your commits please 🙂

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeana-redhat jeana-redhat added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs gitops labels Nov 6, 2023
@jeana-redhat jeana-redhat added this to the Continuous Release milestone Nov 6, 2023
@masauso-lungu
Copy link
Contributor Author

@jeana-redhat are you able to approve the change request made by Sri?, it is blocking the build. I have already addressed the changes requested.

@jeana-redhat jeana-redhat dismissed Srivaralakshmi’s stale review November 6, 2023 21:10

Changes are addressed, requestor is unavailable to acknowledge

@jeana-redhat
Copy link
Contributor

@jeana-redhat are you able to approve the change request made by Sri?, it is blocking the build. I have already addressed the changes requested.

I "dismissed" it, which I have not done before. To get a new build, I think it needs to be closed and reopened.

@jeana-redhat
Copy link
Contributor

closing/reopening for a new build

@jeana-redhat jeana-redhat reopened this Nov 6, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@masauso-lungu masauso-lungu removed the request for review from Srivaralakshmi November 7, 2023 10:35
@varshab1210
Copy link

LGTM, thanks

@masauso-lungu
Copy link
Contributor Author

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 7, 2023
@kalexand-rh kalexand-rh closed this Nov 7, 2023
@kalexand-rh kalexand-rh reopened this Nov 7, 2023
@masauso-lungu
Copy link
Contributor Author

Do not merge. Wait for a merge request. Thank you.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 8, 2023

New changes are detected. LGTM label has been removed.

@masauso-lungu
Documentation for GitOps 1.8.6 release notes
f500988 
Updated the release date to 07.11.2023.

Replaced the Errata link holder with one redirecting to customer portal.

Updated the errata link with the public one and chaanged the issue date.
@masauso-lungu
Copy link
Contributor Author

/label merge-review-needed

The product has been shipped live, kindly merge this PR asap

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 8, 2023
@abhatt-rh
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Nov 8, 2023
@abhatt-rh abhatt-rh closed this Nov 8, 2023
@abhatt-rh abhatt-rh reopened this Nov 8, 2023
@abhatt-rh abhatt-rh closed this Nov 8, 2023
@abhatt-rh abhatt-rh reopened this Nov 8, 2023
@abhatt-rh abhatt-rh merged commit 2bb5d99 into openshift:gitops-docs Nov 8, 2023
1 check passed
@abhatt-rh
Copy link
Contributor

/cherrypick gitops-docs-1.8

@openshift-cherrypick-robot
Copy link

@abhatt-rh: #67076 failed to apply on top of branch "gitops-docs-1.8":

Applying: Documentation for GitOps 1.8.6 release notes
Using index info to reconstruct a base tree...
M	release_notes/gitops-release-notes.adoc
Falling back to patching base and 3-way merge...
Auto-merging release_notes/gitops-release-notes.adoc
CONFLICT (content): Merge conflict in release_notes/gitops-release-notes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Documentation for GitOps 1.8.6 release notes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@masauso-lungu masauso-lungu mentioned this pull request Nov 8, 2023
Merged
@abhatt-rh abhatt-rh removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 8, 2023
This was referenced Nov 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrietgrace harrietgrace harrietgrace left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi approved these changes

Assignees

@iam-veeramalla iam-veeramalla

@Srivaralakshmi Srivaralakshmi

Labels
dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs gitops peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@masauso-lungu @ocpdocs-previewbot @iam-veeramalla @jeana-redhat @Srivaralakshmi @varshab1210 @abhatt-rh @openshift-cherrypick-robot @harrietgrace @kalexand-rh