Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCCDDF-122 #67096

Merged
merged 1 commit into from
Oct 31, 2023
Merged

HCCDDF-122 #67096

merged 1 commit into from
Oct 31, 2023

Conversation

smunje1
Copy link
Contributor

@smunje1 smunje1 commented Oct 31, 2023

HCCDDF-122: [DDF] Attribute {ServerlessProductName} is visible in heading 1.1 text of the published documentation.

Aligned team: Service Delivery
OCP version for cherry-picking: enterprise-4.14+
JIRA issues: HCCDDF-122
Preview pages: Click to see the build preview in your browser for OSD
SME review : NA
QE review: NA
Peer review completed: @mletalie

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2023
@ocpdocs-previewbot
Copy link

Copy link

openshift-ci bot commented Oct 31, 2023

@mletalie: The label(s) /label peer-review-in-process cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-in-process

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mletalie
Copy link
Contributor

/lgtm

@mletalie
Copy link
Contributor

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 31, 2023
@mletalie
Copy link
Contributor

/label peer-review-in-progress

@mletalie
Copy link
Contributor

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Oct 31, 2023
@mletalie
Copy link
Contributor

/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Oct 31, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2023
@bmcelvee
Copy link
Contributor

No QE review needed.

@bmcelvee bmcelvee merged commit f5e04ae into openshift:main Oct 31, 2023
1 check passed
@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.14

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #67105

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@bmcelvee: new pull request created: #67106

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants