Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS#16954: AWS Outposts documentation doesn't reflect the correct support status #67464

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ogradyp
Copy link
Contributor

@ogradyp ogradyp commented Nov 7, 2023

https://issues.redhat.com/browse/OCPBUGS-16954 AWS Outposts documentation doesn't reflect the correct support status

Applies to OpenShift version : 4.12, 4.13 & 4.14

Preview: Installing a cluster on AWS with remote workers on AWS Outposts

Reporter review completed by @makentenza
Peer review completed by @stesmith

Thank you.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 7, 2023
@openshift-ci-robot
Copy link

@ogradyp: This pull request references Jira Issue OCPBUGS-16954, which is invalid:

  • expected Jira Issue OCPBUGS-16954 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2023
OCPBUGS-16954: Technology Preview feature only snippet added
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 10, 2023
@ocpdocs-previewbot
Copy link

@makentenza
Copy link
Contributor

LGTM

@StephenJamesSmith
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2023
@sferich888
Copy link
Contributor

/lgtm
/label px-approve

Copy link

openshift-ci bot commented Nov 21, 2023

@sferich888: The label(s) /label px-approve cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, peer-review-done, peer-review-in-progress, peer-review-needed, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/lgtm
/label px-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xltian
Copy link

xltian commented Nov 22, 2023

lgtm

@makentenza
Copy link
Contributor

@ogradyp please note that this also applies now to 4.14 since the release and documentation is out already

@kalexand-rh
Copy link
Contributor

LGTM.

Since this also applies to 4.14, open a separate PR that targets enterprise-4.14 and link it to this one. Unless @sferich888 objects, the approvals for this PR also apply to the one for 4.14.

@betherly
Copy link

/lgtm

@ogradyp
Copy link
Contributor Author

ogradyp commented Nov 29, 2023

This PR has received all of the required CM approvals.

@openshift-ci-robot
Copy link

@ogradyp: This pull request references Jira Issue OCPBUGS-16954, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead
  • expected Jira Issue OCPBUGS-16954 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-16954 AWS Outposts documentation doesn't reflect the correct support status

Applies to OpenShift version : 4.12, 4.13 & 4.14

Preview: Installing a cluster on AWS with remote workers on AWS Outposts

Reporter review completed by @makentenza
Peer review completed by @stesmith

Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ogradyp
Copy link
Contributor Author

ogradyp commented Nov 29, 2023

/jira refresh

@openshift-ci-robot
Copy link

@ogradyp: This pull request references Jira Issue OCPBUGS-16954, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected Jira Issue OCPBUGS-16954 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh changed the title OCPBUGS-16954: AWS Outposts documentation doesn't reflect the correct support status OCPBUGS#16954: AWS Outposts documentation doesn't reflect the correct support status Nov 29, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 29, 2023
@openshift-ci-robot
Copy link

@ogradyp: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

https://issues.redhat.com/browse/OCPBUGS # 16954 AWS Outposts documentation doesn't reflect the correct support status

Applies to OpenShift version : 4.12, 4.13 & 4.14

Preview: Installing a cluster on AWS with remote workers on AWS Outposts

Reporter review completed by @makentenza
Peer review completed by @stesmith

Thank you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-done Signifies that the peer review team has reviewed this PR labels Nov 30, 2023
@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 1, 2023
@dfitzmau
Copy link
Contributor

dfitzmau commented Dec 1, 2023

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.

Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

@ogradyp
Copy link
Contributor Author

ogradyp commented Dec 19, 2023

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.

Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

Hi @dfitzmau

Apologies for the delay.

The topic itself, which is the most critical information when it comes to the installation, did not include the TP note, see here
https://docs.openshift.com/container-platform/4.12/installing/installing_aws/installing-aws-outposts-remote-workers.html

This PR now rectifies that at the top of the topic, for 4.12, 4.13, and 41., see here
https://67464--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-outposts-remote-workers

The Release Notes / Installation Technology Preview features table in 4.12 also included this information, see here
https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-technology-preview

Thanks
Padraig

@dfitzmau
Copy link
Contributor

dfitzmau commented Dec 19, 2023

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.
Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

Hi @dfitzmau

Apologies for the delay.

The topic itself, which is the most critical information when it comes to the installation, did not include the TP note, see here https://docs.openshift.com/container-platform/4.12/installing/installing_aws/installing-aws-outposts-remote-workers.html

This PR now rectifies that at the top of the topic, for 4.12, 4.13, and 41., see here https://67464--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-outposts-remote-workers

The Release Notes / Installation Technology Preview features table in 4.12 also included this information, see here https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-technology-preview

Thanks Padraig

Thanks for the reply. I see the entry in the 4.12 release notes, but the 4.13 + release note docs should also have AWS Outpost Platform in the TP table listed? Feature is still TP for 4.13 and 4.14?

Screenshot from 2023-12-19 12-51-26

@ogradyp
Copy link
Contributor Author

ogradyp commented Dec 19, 2023

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.
Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

Hi @dfitzmau
Apologies for the delay.
The topic itself, which is the most critical information when it comes to the installation, did not include the TP note, see here https://docs.openshift.com/container-platform/4.12/installing/installing_aws/installing-aws-outposts-remote-workers.html
This PR now rectifies that at the top of the topic, for 4.12, 4.13, and 41., see here https://67464--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-outposts-remote-workers
The Release Notes / Installation Technology Preview features table in 4.12 also included this information, see here https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-technology-preview
Thanks Padraig

Thanks for the reply. I see the entry in the 4.12 release notes, but the 4.13 + release note docs should also have AWS Outpost Platform in the TP table listed? Feature is still TP for 4.13 and 4.14?

Screenshot from 2023-12-19 12-51-26

Yes, the feature is still TP for 4.13 and 4.14.

@dfitzmau
Copy link
Contributor

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.
Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

Hi @dfitzmau
Apologies for the delay.
The topic itself, which is the most critical information when it comes to the installation, did not include the TP note, see here https://docs.openshift.com/container-platform/4.12/installing/installing_aws/installing-aws-outposts-remote-workers.html
This PR now rectifies that at the top of the topic, for 4.12, 4.13, and 41., see here https://67464--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-outposts-remote-workers
The Release Notes / Installation Technology Preview features table in 4.12 also included this information, see here https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-technology-preview
Thanks Padraig

Thanks for the reply. I see the entry in the 4.12 release notes, but the 4.13 + release note docs should also have AWS Outpost Platform in the TP table listed? Feature is still TP for 4.13 and 4.14?
Screenshot from 2023-12-19 12-51-26

Yes, the feature is still TP for 4.13 and 4.14.

Great. Will you be creating separate PRs to update the 4.13 and 4.14 TP tables in the respective release notes docs?

@ogradyp
Copy link
Contributor Author

ogradyp commented Dec 19, 2023

Hi @ogradyp .

QE review: QE has approved this change.

Section is missing from the description box of this PR.
Should the AWS Outpost feature be added to the installation TP table in the release notes for 4.14, 4.13, and 4.12? This would provide better visibility of the feature in a commonly referenced source for checking support statuses of features.

Hi @dfitzmau
Apologies for the delay.
The topic itself, which is the most critical information when it comes to the installation, did not include the TP note, see here https://docs.openshift.com/container-platform/4.12/installing/installing_aws/installing-aws-outposts-remote-workers.html
This PR now rectifies that at the top of the topic, for 4.12, 4.13, and 41., see here https://67464--docspreview.netlify.app/openshift-enterprise/latest/installing/installing_aws/installing-aws-outposts-remote-workers
The Release Notes / Installation Technology Preview features table in 4.12 also included this information, see here https://docs.openshift.com/container-platform/4.12/release_notes/ocp-4-12-release-notes.html#ocp-4-12-technology-preview
Thanks Padraig

Thanks for the reply. I see the entry in the 4.12 release notes, but the 4.13 + release note docs should also have AWS Outpost Platform in the TP table listed? Feature is still TP for 4.13 and 4.14?
Screenshot from 2023-12-19 12-51-26

Yes, the feature is still TP for 4.13 and 4.14.

Great. Will you be creating separate PRs to update the 4.13 and 4.14 TP tables in the respective release notes docs?

This PR is created in 4.13, deals with the update to the install module, and needs to be cherrypicked to 4.12 and 4.14.

The cleanest way to deal with the update to the RN TP table is 2 separate PRs - 1 for 4.13, 1 for 4.14.

@dfitzmau
Copy link
Contributor

Thanks, @ogradyp . Yes, creating seprate PRs to update the TP tables in 4.13 and 4.14 sounds good to me.

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 20, 2023
@ogradyp
Copy link
Contributor Author

ogradyp commented Dec 20, 2023

Thanks, @ogradyp . Yes, creating seprate PRs to update the TP tables in 4.13 and 4.14 sounds good to me.

/remove-label peer-review-in-progress

/label peer-review-done

Thanks for your review @dfitzmau of this PR.

I have also added you as reviewer of these two separate PRs:
TP table for 4.14 #69625
TP table for 4.13 #69617

Many Thanks
Padraig

@dfitzmau
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 21, 2023
@mburke5678
Copy link
Contributor

@ogradyp As I understand, we are supposed to CP from main only, and not between branches. I can merge this to 4.13. But, can you add the TP note to 4.14 through your 4.14 release note PR and pull a new PR for 4.12?

@ogradyp
Copy link
Contributor Author

ogradyp commented Dec 21, 2023

@ogradyp As I understand, we are supposed to CP from main only, and not between branches. I can merge this to 4.13. But, can you add the TP note to 4.14 through your 4.14 release note PR and pull a new PR for 4.12?

Thanks @mburke5678 for your review.

As requested please see :

@mburke5678 mburke5678 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 21, 2023
@mburke5678 mburke5678 added this to the Continuous Release milestone Dec 21, 2023
@mburke5678 mburke5678 merged commit 13b96a8 into openshift:enterprise-4.13 Dec 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet