Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-7593: Netobserv RTT #67540

Merged
merged 1 commit into from Jan 23, 2024
Merged

OSDOCS-7593: Netobserv RTT #67540

merged 1 commit into from Jan 23, 2024

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Nov 7, 2023 •
edited

For peer review/merge review:
Merge to only the no-1.5 branch - no cherrypicks are required.
This PR is part of an experiment for simplifying merges for asynchronous content, and I will open one PR against main to incorporate all of the Network Observability 1.5 content just before its GA.

Version(s):

4.11+
For Network Observability Operator 2/19/24 1.5 release.
Issue:

https://issues.redhat.com/browse/OSDOCS-7593
Link to docs preview:

Overview: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT-overview_nw-observe-network-traffic

Working with RTT: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-7593 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 7, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 7, 2023 •
edited

🤖 Updated build preview is available at:
https://67540--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37287

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 9, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-7593 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7593
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 9, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-7593 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-7593
Link to docs preview:

Overview: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT-overview_nw-observe-network-traffic

Working with RTT: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas force-pushed the OSDOCS-7593 branch 2 times, most recently from c6845ea to 3cbcbe3 Compare November 13, 2023 18:17
@skrthomas
Copy link
Contributor Author

@Amoghrd @jpinsonneau This is the first draft for RTT docs. Can you PTAL and let me know your feedback?

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-7593 which is a valid jira issue.

In response to this:

Version(s):

4.11+
For Network Observability Operator 2/19/24 release.
Issue:

https://issues.redhat.com/browse/OSDOCS-7593
Link to docs preview:

Overview: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT-overview_nw-observe-network-traffic

Working with RTT: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-7593 which is a valid jira issue.

In response to this:

Version(s):

4.11+
For Network Observability Operator 2/19/24 1.5 release.
Issue:

https://issues.redhat.com/browse/OSDOCS-7593
Link to docs preview:

Overview: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT-overview_nw-observe-network-traffic

Working with RTT: https://67540--docspreview.netlify.app/openshift-enterprise/latest/network_observability/observing-network-traffic#network-observability-RTT_nw-observe-network-traffic
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas marked this pull request as draft November 13, 2023 20:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@skrthomas skrthomas force-pushed the OSDOCS-7593 branch 3 times, most recently from e063c4c to 18c865e Compare November 15, 2023 22:49
@Amoghrd
Copy link

Amoghrd commented Dec 1, 2023

Similar to what I said in the DNS PR, for RTT, it is strongly recommended to use sampling =1 for accurate metrics

jpinsonneau
jpinsonneau reviewed Dec 18, 2023
View reviewed changes
modules/network-observability-RTT.adoc Outdated
.. In the *Overview*, select new choices in *Manage panels* to choose which graphical visualizations of RTT to display.
.. In the *Traffic flows* table, the *Flow RTT* column can be seen, and you can manage display in *Manage columns*.
.. In the *Traffic Flows* view, you can also expand the side panel to view more information about RTT.
.. Click *Common* filters -> *Protocol*. Filter the network flow data based on *Protocol TCP* to show flows with nonzero values.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have some zeros in that case, even with sampling 1
https://issues.redhat.com/browse/NETOBSERV-1390

@msherif1234 is it worth putting a fancy technical limitation here ?
Or maybe just filter "Flow RTT > 0" as mentioned below is good enough ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this bug has been closed now, and the behavior is working as expected so I don't think there's anything additional to document here. Can you confirm @msherif1234 @jpinsonneau ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably adding Direction = Ingress since this measurement was done for incoming TCP traffic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks. I re-wrote this section as "Example filtering" to try within the procedure.

@tmalove
Copy link
Contributor

tmalove commented Jan 8, 2024

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 8, 2024
@Amoghrd
Copy link

Amoghrd commented Jan 15, 2024

/remove qe-approved

@skrthomas skrthomas force-pushed the OSDOCS-7593 branch 3 times, most recently from 113570a to 4b0c5fb Compare January 16, 2024 15:56
@skrthomas skrthomas force-pushed the OSDOCS-7593 branch 2 times, most recently from b2878c8 to 0ce4c68 Compare January 17, 2024 15:20
@skrthomas
Copy link
Contributor Author

@Amoghrd @msherif1234 I incorporated your feedback. Can you please have another look, and approve if all looks OK?

@Amoghrd
Copy link

Amoghrd commented Jan 18, 2024

New changes LGTM

@msherif1234
Copy link

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@skrthomas skrthomas added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 22, 2024
@skrthomas skrthomas added this to the Continuous Release milestone Jan 22, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 23, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2024

New changes are detected. LGTM label has been removed.

@stevsmit stevsmit merged commit 4d8711b into openshift:no-1.5 Jan 23, 2024
1 check passed
@skrthomas skrthomas removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherif1234 msherif1234 msherif1234 left review comments

@Amoghrd Amoghrd Amoghrd left review comments

@tmalove tmalove tmalove left review comments

@jpinsonneau jpinsonneau jpinsonneau left review comments

Assignees

@msherif1234 msherif1234

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@skrthomas @openshift-ci-robot @ocpdocs-previewbot @Amoghrd @tmalove @msherif1234 @jpinsonneau @stevsmit