Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNV#33978: adding OCP Virt support to ROSA RNs #67657

Merged
merged 1 commit into from
Nov 9, 2023
Merged

CNV#33978: adding OCP Virt support to ROSA RNs #67657

merged 1 commit into from
Nov 9, 2023

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Nov 9, 2023 •
edited

Version(s): 4.14+

Issue: related to CNV-33978

Link to docs preview: https://67657--docspreview.netlify.app/openshift-rosa/latest/rosa_release_notes/rosa-release-notes#rosa-q4-2023_rosa-whats-new

QE review:

  • QE has approved this change.

Additional information: Also adding the :VirtProductName: OpenShift Virtualization attribute to the _attributes/attributes-openshift-dedicated.adoc file.

@ousleyp ousleyp added this to the Continuous Release milestone Nov 9, 2023
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 9, 2023 •
edited

🤖 Updated build preview is available at:
https://67657--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/32520

@laujohns89
Copy link

LGTM!

@ousleyp
Copy link
Member Author

ousleyp commented Nov 9, 2023

@dbasunag or @orenc1 - can you please review this PR? It adds a release note to the ROSA docs re: CNV support. Thanks!

@ousleyp ousleyp merged commit 31b3fa3 into openshift:main Nov 9, 2023
1 check passed
@ousleyp
Copy link
Member Author

ousleyp commented Nov 9, 2023

/cherrypick enterprise-4.15

@ousleyp
Copy link
Member Author

ousleyp commented Nov 9, 2023

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #67679

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Nov 9, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #67680

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbasunag dbasunag dbasunag approved these changes

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 CNV Label for all CNV PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ousleyp @ocpdocs-previewbot @laujohns89 @openshift-cherrypick-robot @dbasunag