Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP 1.3 DataMover restore hook issue #67817

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

RichardHoch
Copy link
Contributor

@RichardHoch RichardHoch commented Nov 13, 2023

OADP 1.3; OCP 4.11+

Resolves https://issues.redhat.com/browse/OADP-3059 by writing a short note to describe the problem.

Preview: https://67817--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/data-mover-intro [end of introduction]

OADP QA approved.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 13, 2023

🤖 Updated build preview is available at:
https://67817--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35081

@RichardHoch RichardHoch marked this pull request as ready for review November 13, 2023 17:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2023
@amastbau
Copy link

neeed to check about 1.2
i think it has the same issue,
but i could be wrong

@amastbau
Copy link

LGTM

@RichardHoch
Copy link
Contributor Author

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 27, 2023
@RichardHoch
Copy link
Contributor Author

@anarnold97 I have written the note as a snippet so we can move it easily later, if needed. For now, I have added the snippet to the end of the OADP Data Mover Introduction. If you have a different suggestion for its location, please let me know. I'm asking for a peer review in parallel to save time.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 27, 2023
@mburke5678
Copy link
Contributor

@RichardHoch One question. Otherwise LGTM

@RichardHoch
Copy link
Contributor Author

@mburke5678 Unfortunately, there is no workaround. This should be merged as is with OADP 1.3's GA, which is scheduled for today. Thanks!

@RichardHoch
Copy link
Contributor Author

/label merge-review-needed

@RichardHoch
Copy link
Contributor Author

RichardHoch commented Nov 29, 2023

Please merge today; release has gone GA. Thanks.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023
@ousleyp ousleyp added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 29, 2023
@ousleyp ousleyp added the peer-review-done Signifies that the peer review team has reviewed this PR label Nov 29, 2023
@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

LGTM

@ousleyp ousleyp merged commit d67a0fa into openshift:main Nov 29, 2023
1 check passed
@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

/cherrypick enterprise-4.15

@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

/cherrypick enterprise-4.14

@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

/cherrypick enterprise-4.13

@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@ousleyp: new pull request created: #68583

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp
Copy link
Member

ousleyp commented Nov 29, 2023

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@ousleyp: new pull request created: #68584

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request created: #68585

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request created: #68586

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@ousleyp: new pull request created: #68587

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ousleyp ousleyp removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants