Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-8253: Improved LokiStack integration #67836

Merged
merged 1 commit into from Jan 29, 2024
Merged

OSDOCS-8253: Improved LokiStack integration #67836

merged 1 commit into from Jan 29, 2024

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Nov 13, 2023 •
edited

For peer review/merge review:
Merge to only the no-1.5 branch - no cherrypicks are required.
This PR is part of an experiment for simplifying merges for asynchronous content, and I will open one PR against main to incorporate all of the Network Observability 1.5 content just before its GA.

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

IncludeList

Network Observability metrics dashboards add includeList

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 13, 2023 •
edited

🤖 Updated build preview is available at:
https://67836--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37314

@skrthomas skrthomas force-pushed the OSDOCS-8253 branch 2 times, most recently from 9300ad5 to 030d666 Compare November 16, 2023 15:42
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

Installing the Network Observability Operator

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

Installing the Network Observability Operator

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

Installing the Network Observability Operator

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2023
@skrthomas skrthomas added this to the Continuous Release milestone Nov 17, 2023
@skrthomas skrthomas marked this pull request as draft November 17, 2023 20:16
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2023
@skrthomas
Copy link
Contributor Author

@nathan-weinberg @jpinsonneau @acmenezes Here's my draft PR for Improved LokiStack configuration. Please let me know your feedback. I think I've got all the doc impacts from this jira, but let me know if I'm missing anything.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

Installing the Network Observability Operator

IncludeList

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 17, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

Installing the Network Observability Operator

IncludeList

Network Observability metrics dashboards

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas force-pushed the OSDOCS-8253 branch 5 times, most recently from a059873 to c3b98e7 Compare December 14, 2023 18:42
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8253 which is a valid jira issue.

In response to this:

For peer review/merge review:
Merge to only the no-1.5 branch - no cherrypicks are required.
This PR is part of an experiment for simplifying merges for asynchronous content, and I will open one PR against main to incorporate all of the Network Observability 1.5 content just before its GA.

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8253
Link to docs preview:

API Version updates:

Loki Installation step simplification

IncludeList

Network Observability metrics dashboards add includeList

Unrelated updates

Packet Drop and DNS Overview nesting adjustment

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas marked this pull request as ready for review January 4, 2024 16:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 4, 2024
@skrthomas
Copy link
Contributor Author

skrthomas commented Jan 26, 2024 •
edited

@jpinsonneau I updated the fields to Advanced. Here's the links to the lines in the files:

@skrthomas skrthomas added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 29, 2024
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 29, 2024
@mburke5678
Copy link
Contributor

@skrthomas Can you squash the commits?

@skrthomas
Copy link
Contributor Author

@mburke5678 Yep, sure can. Sorry about that.I didn't realize there were 2 commits here. Must've happened when I rebased and I didn't realize it.

@skrthomas
OSDOCS-8253: Improved LokiStack integration
4c0dec3 
OSDOCS-8253: API version updates
@mburke5678 mburke5678 merged commit 7d96834 into openshift:no-1.5 Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-weinberg nathan-weinberg nathan-weinberg left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@Amoghrd Amoghrd Amoghrd left review comments

@jpinsonneau jpinsonneau jpinsonneau left review comments

@jotak jotak jotak approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@skrthomas @openshift-ci-robot @ocpdocs-previewbot @jotak @mburke5678 @nathan-weinberg @jeana-redhat @Amoghrd @jpinsonneau