Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-5730: support /retest for pipelineRuns triggered on push event #68386

Merged
merged 1 commit into from
Nov 29, 2023
Merged

RHDEVDOCS-5730: support /retest for pipelineRuns triggered on push event #68386

merged 1 commit into from
Nov 29, 2023

Conversation

eromanova97
Copy link
Contributor

@eromanova97 eromanova97 commented Nov 24, 2023 •
edited

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting or canceling a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link:

SME review:

QE review:

Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 24, 2023 •
edited

🤖 Updated build preview is available at:
https://68386--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35120

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting a pipeline run using Pipelines as Code

SME review:

QE review:

Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

Hello @savitaashture @ppitonak PTAL at this PR and leave feedback. Thank you!

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 24, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

Peer review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 28, 2023
@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Nov 28, 2023
bergerhoffer
bergerhoffer reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, overall nice job!

modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-pipeline-run-using-pipelines-as-code.adoc Outdated

* The `/test <pipelinerun-name>` and `/retest <pipelinerun-name>` comment restarts a specific pipeline run.

* The `/cancel` comment cancels all pipeline runs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are talking about canceling pipeline runs. Just checking if this is applicable to mention here in a section that talks just about restarting runs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekristova I think this makes sense. Can you try adding mentions of canceling of pipeline runs to the header and the text, even if this needs a re-review? I understand timing is tight, making GA date on this one is not THAT critical, doing it right is probably more important even if the doc takes an extra day (should not be more than that).

@bergerhoffer
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting and canceling a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

Peer review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bergerhoffer
bergerhoffer reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things, otherwise LGTM!

modules/op-restarting-and-canceling-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-and-canceling-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
modules/op-restarting-and-canceling-pipeline-run-using-pipelines-as-code.adoc Outdated Show resolved Hide resolved
@savitaashture
Copy link

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting and canceling a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Nov 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 29, 2023 •
edited by openshift-ci bot

@ekristova: This pull request references RHDEVDOCS-5730 which is a valid jira issue.

In response to this:

Version(s): CP to pipelines-docs-1.13

Issue: RHDEVDOCS-5730

Preview link: Restarting or canceling a pipeline run using Pipelines as Code

SME review: @savitaashture

QE review: @ppitonak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eromanova97 eromanova97 changed the title [WIP] RHDEVDOCS-5730: support /retest for pipelineRuns triggered on push event RHDEVDOCS-5730: support /retest for pipelineRuns triggered on push event Nov 29, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2023
@mburke5678 mburke5678 merged commit d6bcb38 into openshift:pipelines-docs Nov 29, 2023
1 check passed
@mburke5678
Copy link
Contributor

/cherrypick pipelines-docs-1.13

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #68610

In response to this:

/cherrypick pipelines-docs-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 29, 2023
Merged
@eromanova97 eromanova97 deleted the RHDEVDOCS-5730 branch April 18, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@savitaashture savitaashture savitaashture approved these changes

@mramendi mramendi mramendi left review comments

@ppitonak ppitonak ppitonak approved these changes

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@eromanova97 @openshift-ci-robot @ocpdocs-previewbot @bergerhoffer @savitaashture @mburke5678 @openshift-cherrypick-robot @ppitonak @mramendi