RHDEVDOCS 5729 overriding a task in remote pipeline #68447
Conversation
openshift-ci
bot
added
the
size/S
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/34921 |
|
|
||
| By default, if you use a remote pipeline annotation in a pipeline run, {pac} uses all the tasks that are a part of the remote pipeline. | ||
|
|
||
| To override a task, you can add an annotation for a task with the same name to the remote pipeline annotation. |
There was a problem hiding this comment.
nit: task with the same name as in remote pipeline to the pipelinerun annotation
|
lgtm |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
mburke5678
added
the
peer-review-in-progress
|
|
||
| By default, if you use a remote pipeline annotation in a pipeline run, {pac} uses all the tasks that are a part of the remote pipeline. | ||
|
|
||
| To override a task, you can add an annotation for a task with the same name as a task in the pipeline that the remote pipeline annotation references. |
There was a problem hiding this comment.
This line is not clear to me, but I am not familiar with pipelines. Maybe something like:
| To override a task, you can add an annotation for a task with the same name as a task in the pipeline that the remote pipeline annotation references. | |
| You can override a task in a remote pipeline by adding a task that has the same name as an annotation in the pipeline run. |
|
@mramendi One nit. Otherwise LGTM |
mburke5678
added
peer-review-done
mramendi
force-pushed
the
RHDEVDOCS-5729
branch
from
d0c384d
to
67f1e65
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/label merge-review-in-progress |
openshift-ci
bot
added
the
merge-review-in-progress
| .Example pipeline run definition referencing a remote pipeline and overriding a task | ||
| [source,yaml] | ||
| ---- | ||
| kind: PipelineRun |
There was a problem hiding this comment.
Should this have an apiVersion here?
| pipelinesascode.tekton.dev/task: "./my-git-clone-task.yaml" | ||
| ---- | ||
|
|
||
| For this example, assume the remote task found at \https://git.provider/raw/pipeline.yaml includes a task named `git-clone` and the task that the `my-git-clone-task.yaml` file defines is also named `git-clone`. |
There was a problem hiding this comment.
the URL here should probably be in backticks
There was a problem hiding this comment.
@bergerhoffer I agree with your notes and thanks for not holding the merge! We have a GA tomorrow and the suggested changes require a new round of reviews. I am making a separate PR but it might get merged after the GA.
|
/cherrypick pipelines-docs-1.13 |
|
@bergerhoffer: new pull request created: #68557 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
cp to pipelines-docs-1.13
Issue:
RHDEVDOCS 5729
Link to docs preview:
https://68447--docspreview.netlify.app/openshift-pipelines/latest/pac/using-pac-resolver#overriding-tasks-in-remote-pipeline_using-pac-resolver
QE review:
Additional information: