Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-8330: Configure limits via Subscription, not CSV #68486

Merged
merged 1 commit into from Dec 4, 2023
Merged

OSDOCS-8330: Configure limits via Subscription, not CSV #68486

merged 1 commit into from Dec 4, 2023

Conversation

skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Nov 28, 2023 •
edited

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8330
https://issues.redhat.com/browse/NETOBSERV-1373
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 28, 2023 •
edited

🤖 Updated build preview is available at:
https://68486--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35974

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8330
https://issues.redhat.com/browse/NETOBSERV-1373
Link to docs preview:

https://68486--docspreview.netlify.app/openshift-enterprise/latest/network_observability/troubleshooting-network-observability#controller-manager-pod-runs-out-of-memory_network-observability-troubleshooting
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jotak
jotak reviewed Nov 29, 2023
View reviewed changes
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated

.Procedure

. Run the following command to patch the CSV:
* Increase memory limits to `800Mi` by editing the `Subscription` object:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it clear that 800Mi is just an example, not a hard requirement?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, maybe we can link a reference to the Resource Recommendations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to link there. I will add that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added that link.

@skrthomas skrthomas requested review from nathan-weinberg and removed request for nathan-weinberg November 29, 2023 15:37
@skrthomas skrthomas force-pushed the OSDOCS-8330 branch 3 times, most recently from b829ee4 to 6a0174d Compare November 29, 2023 18:39
jotak
jotak approved these changes Nov 30, 2023
View reviewed changes
Copy link

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @skrthomas @nathan-weinberg , lgtm!

@nathan-weinberg
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-8330
https://issues.redhat.com/browse/NETOBSERV-1373
Link to docs preview:

https://68486--docspreview.netlify.app/openshift-enterprise/latest/network_observability/troubleshooting-network-observability#controller-manager-pod-runs-out-of-memory_network-observability-troubleshooting
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas added this to the Continuous Release milestone Nov 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2023 •
edited by openshift-ci bot

@skrthomas: This pull request references OSDOCS-8330 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Version(s):

4.11+
Issue:

https://issues.redhat.com/browse/OSDOCS-8330
https://issues.redhat.com/browse/NETOBSERV-1373
Link to docs preview:

https://68486--docspreview.netlify.app/openshift-enterprise/latest/network_observability/troubleshooting-network-observability#controller-manager-pod-runs-out-of-memory_network-observability-troubleshooting
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas added the peer-review-needed Signifies that the peer review team needs to review this PR label Nov 30, 2023
@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Nov 30, 2023
dfitzmau
dfitzmau reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skrthomas . Great work. I added some comments inline.

modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated Show resolved Hide resolved
modules/troubleshooting-network-observability-controller-manager-pod-out-of-memory.adoc Outdated Show resolved Hide resolved
@dfitzmau
Copy link
Contributor

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Nov 30, 2023
@skrthomas
Copy link
Contributor Author

Thanks @dfitzmau !

@skrthomas skrthomas added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 4, 2023
@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 4, 2023
@skrthomas
Copy link
Contributor Author

Thanks @bscott-rh !

@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 4, 2023
@skrthomas skrthomas merged commit 6385bce into openshift:main Dec 4, 2023
1 check passed
@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.11

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.13

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.14

@skrthomas
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #68892

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 4, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #68893

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #68894

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #68895

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2023
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #68896

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotak jotak jotak approved these changes

@nathan-weinberg nathan-weinberg nathan-weinberg left review comments

@dfitzmau dfitzmau dfitzmau left review comments

@bscott-rh bscott-rh bscott-rh left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@skrthomas @openshift-ci-robot @ocpdocs-previewbot @nathan-weinberg @dfitzmau @openshift-cherrypick-robot @jotak @bscott-rh