Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-18769: autoscaler fixes #68594

Merged
merged 1 commit into from
Dec 5, 2023
Merged

OCPBUGS-18769: autoscaler fixes #68594

merged 1 commit into from
Dec 5, 2023

Conversation

jldohmann
Copy link
Contributor

@jldohmann jldohmann commented Nov 29, 2023 •
edited

@jldohmann jldohmann added this to the Continuous Release milestone Nov 29, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 29, 2023
@openshift-ci-robot
Copy link

@jldohmann: This pull request references Jira Issue OCPBUGS-18769, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OCPBUGS-18769

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 29, 2023
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 29, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 29, 2023 •
edited

🤖 Updated build preview is available at:
https://68594--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/35621

@jldohmann
Copy link
Contributor Author

@melvinjoseph86 could you PTAL at this docs PR for QE ack? thank you

melvinjoseph86
melvinjoseph86 reviewed Dec 1, 2023
View reviewed changes
Copy link

@melvinjoseph86 melvinjoseph86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also as the requestor asked we can modify the Step 7, "Create a new ScaledObject YAML file, ingress-autoscaler.yaml, that targets the default Ingress Controller deployment".
serverAddress: https://thanos-querier.openshift-monitoring.svc.cluster.local:9091
in the ingress-autoscaler.yaml file.

modules/nw-autoscaling-ingress-controller.adoc Show resolved Hide resolved
@jldohmann jldohmann added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 1, 2023
@nalhadef
Copy link
Contributor

nalhadef commented Dec 1, 2023

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 1, 2023
@nalhadef
Copy link
Contributor

nalhadef commented Dec 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
@nalhadef
Copy link
Contributor

nalhadef commented Dec 1, 2023

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 1, 2023
@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Dec 5, 2023
@melvinjoseph86
Copy link

@melvinjoseph86 could you PTAL at this docs PR for QE ack? thank you

Done

@melvinjoseph86
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-18769, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann merged commit 09ae03d into openshift:main Dec 5, 2023
1 check passed
@openshift-ci-robot
Copy link

@jldohmann: Jira Issue OCPBUGS-18769: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-18769 has been moved to the MODIFIED state.

In response to this:

Version(s): 4.13+

Issue: https://issues.redhat.com/browse/OCPBUGS-18769

Link to docs preview: https://68594--docspreview.netlify.app/openshift-enterprise/latest/networking/ingress-operator#nw-autoscaling-ingress-controller_configuring-ingress

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.15

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.14

@jldohmann
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 5, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #68953

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #68954

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 5, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jldohmann: new pull request created: #68955

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jldohmann jldohmann deleted the OCPBUGS-18769 branch December 5, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melvinjoseph86 melvinjoseph86 melvinjoseph86 left review comments

Assignees

@nalhadef nalhadef

Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jldohmann @openshift-ci-robot @ocpdocs-previewbot @nalhadef @melvinjoseph86 @openshift-cherrypick-robot