Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS#23317: Additional resource links replaced with correct RHEL v… #68832

Merged
merged 1 commit into from
Dec 18, 2023
Merged

OCPBUGS#23317: Additional resource links replaced with correct RHEL v… #68832

merged 1 commit into from
Dec 18, 2023

Conversation

aravipra
Copy link
Contributor

@aravipra aravipra commented Dec 4, 2023 •
edited

Version(s):
4.15, 4.14

Issue:
OCPBUGS-23317

Link to docs preview:
Adding a certificate authority bundle to an rpm-ostree image:Additional resources

QE review:

  • QE approval required.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 4, 2023
@openshift-ci-robot
Copy link

@aravipra: This pull request references Jira Issue OCPBUGS-23317, which is invalid:

  • expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…ersions for Microshift

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2023
@aravipra aravipra changed the title OCPBUGS-23317: Additional resource links replaced with correct RHEL v… OCPBUGS#23317: Additional resource links replaced with correct RHEL v… Dec 4, 2023
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 4, 2023
@openshift-ci-robot
Copy link

@aravipra: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.15, 4.14

Issue:
OCPBUGS-23317

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravipra aravipra closed this Dec 7, 2023
@aravipra
Copy link
Contributor Author

aravipra commented Dec 7, 2023

to trigger travis build reopening the PR

@aravipra aravipra reopened this Dec 7, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 7, 2023 •
edited

🤖 Mon Dec 18 09:47:05 - Prow CI generated the docs preview: https://68832--ocpdocs-pr.netlify.app

@dfitzmau
Copy link
Contributor

dfitzmau commented Dec 7, 2023

Hi @aravipra . LGTM. Please get an approval from John George before you send this PR for peer reviews. Would be worthwhile checking that providing links to RHEL 9 docs is sufficient for OCP 4.14 and 4.15.

@aravipra
Copy link
Contributor Author

aravipra commented Dec 7, 2023

adding @jogeo for review and approval

@jogeo
Copy link

jogeo commented Dec 7, 2023

QE approved.

@aravipra
Copy link
Contributor Author

/label peer-review-needed

SME approval in progress. Please review PR meanwhile

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 11, 2023
@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 11, 2023
skrthomas
skrthomas reviewed Dec 11, 2023
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Dec 11, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
dhellmann
dhellmann reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@dfitzmau
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2023

@aravipra: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aravipra
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 18, 2023
@mburke5678 mburke5678 added branch/enterprise-4.14 branch/enterprise-4.15 merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 18, 2023
@mburke5678 mburke5678 merged commit 937a417 into openshift:main Dec 18, 2023
3 checks passed
@mburke5678
Copy link
Contributor

mburke5678 commented Dec 18, 2023 •
edited

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69527

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2023
Merged
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #69528

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhellmann dhellmann dhellmann left review comments

@skrthomas skrthomas skrthomas left review comments

Assignees

@dhellmann dhellmann

@skrthomas skrthomas

Labels
branch/enterprise-4.14 branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@aravipra @openshift-ci-robot @ocpdocs-previewbot @dfitzmau @jogeo @mburke5678 @openshift-cherrypick-robot @dhellmann @skrthomas