Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-3182: quick format fix #69075

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Dec 7, 2023

Quick fix

@adellape made the following suggestion, Not blocking merge for this, but just noticed periods on the ends of these bullets that could be removed in a later PR.

Jira

Version:

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15

Doc preview

https://69075--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/release-notes/oadp-release-notes-1-2#oadp-upgrading-dpa-operator-1-2-0_oadp-release-notes

QE review:

  • [X ] QE has approved this change. See previous PR

Signed-off-by: Andy Arnold <anarnold@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023

@anarnold97: This pull request references OADP-3182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Quick fix

@adellape made the following suggestion, Not blocking merge for this, but just noticed periods on the ends of these bullets that could be removed in a later PR.

Jira

Version:

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15

Doc preview

QE review:

  • [X ] QE has approved this change. See previous PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anarnold97
Copy link
Contributor Author

/label OADP

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs merge-review-needed Signifies that the merge review team needs to review this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2023
@ocpdocs-previewbot
Copy link

@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 7, 2023

@anarnold97: This pull request references OADP-3182 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Quick fix

@adellape made the following suggestion, Not blocking merge for this, but just noticed periods on the ends of these bullets that could be removed in a later PR.

Jira

Version:

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15

Doc preview

https://69075--docspreview.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/release-notes/oadp-release-notes-1-2#oadp-upgrading-dpa-operator-1-2-0_oadp-release-notes

QE review:

  • [X ] QE has approved this change. See previous PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

Combining peer review and merge review since the change is small and recommended by a peer reviewer.

FYI, I updated the preview link in your description to point to this PR's preview

LGTM

@bscott-rh bscott-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 7, 2023
@bscott-rh bscott-rh added this to the Continuous Release milestone Dec 7, 2023
@bscott-rh bscott-rh merged commit b0c445d into openshift:main Dec 7, 2023
1 check passed
@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #69079

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #69080

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #69081

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #69082

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anarnold97
Copy link
Contributor Author

@bscott-rh - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants