Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-3268 [DOC] Release notes small corrections #69552

Merged
merged 1 commit into from
Dec 18, 2023
Merged

OADP-3268 [DOC] Release notes small corrections #69552

merged 1 commit into from
Dec 18, 2023

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Dec 18, 2023 •
edited

Jira

Versions:

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15

Docs preview:

@anarnold97
OADP-3268 [DOC] Release notes small corrections
ba5c5f8 
Signed-off-by: Andy Arnold <anarnold@redhat.com>
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@ocpdocs-previewbot
Copy link

🤖 Mon Dec 18 18:19:50 - Prow CI generated the docs preview: https://69552--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 18, 2023

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Dec 18, 2023
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 18, 2023
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 18, 2023
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 18, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 18, 2023
@anarnold97
Copy link
Contributor Author

@mburke5678 - thanks big man

@michaelryanpeter
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 18, 2023
michaelryanpeter
michaelryanpeter reviewed Dec 18, 2023
View reviewed changes
modules/oadp-release-notes-1-3-0.adoc
@@ -149,7 +149,7 @@ spec:

[NOTE]
====
In OADP 1.4, the `kopia` will become the default `uploaderType` value.
In OADP 1.4, `kopia` will become the default `uploaderType` value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a merge blocker, but please consider creating a follow up PR to reword this sentence. The ISG states that we should avoid claims about future product releases.

Suggested change
In OADP 1.4, `kopia` will become the default `uploaderType` value.
In a future OADP release, it is planned that the `kopia` tool will become the default `uploaderType` value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the format that PX has asked us to use when talking about plans for future releases.

@michaelryanpeter michaelryanpeter added this to the Continuous Release milestone Dec 18, 2023
@michaelryanpeter michaelryanpeter merged commit 2e9169e into openshift:main Dec 18, 2023
3 checks passed
@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.15

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.14

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.13

@michaelryanpeter
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #69570

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Dec 18, 2023
Merged
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #69571

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #69572

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2023
Merged
@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #69573

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 18, 2023
Merged
@anarnold97 anarnold97 mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelryanpeter michaelryanpeter michaelryanpeter left review comments

Assignees

@mburke5678 mburke5678

Labels
lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anarnold97 @ocpdocs-previewbot @mburke5678 @michaelryanpeter @openshift-cherrypick-robot