OADP Datamover readthrough #69706
OADP Datamover readthrough #69706
Conversation
openshift-ci
bot
added
the
size/S
|
🤖 Thu Dec 28 14:15:37 - Prow CI generated the docs preview: https://69706--ocpdocs-pr.netlify.app |
|
/oadp |
|
Fixing a typo, so if we can go straight to merging, that would be appreciated. |
|
/label oadp |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
snarayan-redhat
added
peer-review-in-progress
There was a problem hiding this comment.
Changes look good. Couple of suggestions that may not be related to the changes that you are trying to fix. Just a good to have fix along with your current changes.
One of the changes seem to remove a statement regarding marking backup as complete which I feel needs a go ahead from QE. Let me know if I am missing something here.
| @@ -16,8 +16,7 @@ The Data Mover solution uses the Restic option of VolSync. | |||
|
|
|||
| Data Mover supports backup and restore of CSI volume snapshots only. | |||
|
|
|||
| In OADP 1.2 Data Mover `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. After all async plugin operations are complete, the backup is marked as complete. | |||
|
|
|||
| In OADP 1.2 Data Mover, `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. | |||
There was a problem hiding this comment.
This change is more than just a typo. I think we need a QE approval here?
There was a problem hiding this comment.
@snarayan-redhat The sentence involved is no doubt true, but it has nothing to do with performance improvement, which is the subject of the paragraph. I will leave it in for now so we can fix the typo in the document.
| @@ -16,8 +16,7 @@ The Data Mover solution uses the Restic option of VolSync. | |||
|
|
|||
| Data Mover supports backup and restore of CSI volume snapshots only. | |||
|
|
|||
| In OADP 1.2 Data Mover `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. After all async plugin operations are complete, the backup is marked as complete. | |||
|
|
|||
| In OADP 1.2 Data Mover, `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. | |||
There was a problem hiding this comment.
If you wouldn't mind changing this one too? Thanks for considering.
| In OADP 1.2 Data Mover, `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. | |
| In OADP 1.2 Data Mover, `VolumeSnapshotBackups` (VSBs) and `VolumeSnapshotRestores` (VSRs) are queued by using the VolumeSnapshotMover (VSM). The VSM's performance is improved by specifying a concurrent number of VSBs and VSRs simultaneously `InProgress`. |
snarayan-redhat
added
peer-review-done
RichardHoch
force-pushed
the
datamover_changes
branch
from
0aae95b
to
e788330
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
@RichardHoch: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
snarayan-redhat
added
merge-review-in-progress
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
@snarayan-redhat: new pull request created: #69707 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #69708 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #69709 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #69710 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #69711 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OADP 1.3; OCP 4.11+
Resolves https://issues.redhat.com/browse/OADP-3185 by making a number of minor changes to the discussion of the pre-OADP 1.3 DataMover in the OADP user guide.