[virt] DPDK cluster config: Enable AlignCPUs #69713

orelmisan · 2024-01-01T10:17:51Z

In case the user's worker nodes have SMT [1] enabled, they will probably encounter CNV-31584 [2].

Add an instruction to enable the AlignCPUs enabler in HCO [3], so it will enable [4] KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using
emulator thread isolation.

[1] https://en.wikipedia.org/wiki/Simultaneous_multithreading
[2] https://issues.redhat.com/browse/CNV-31584
[3] kubevirt/hyperconverged-cluster-operator#2695
[4] kubevirt/kubevirt#10872

Version(s):

4.15+

Issue:

https://issues.redhat.com/browse/CNV-31584

Link to docs preview:

https://69713--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-using-dpdk-with-sriov#virt-configuring-cluster-dpdk_virt-using-dpdk-with-sriov

QE review:

QE has approved this change.

Additional information:

orelmisan · 2024-01-01T10:18:08Z

/cc @RamLavi @segevyos

orelmisan · 2024-01-01T10:19:27Z

/cc @bellka5

ocpdocs-previewbot · 2024-01-01T10:24:04Z

🤖 Mon Jan 08 14:06:37 - Prow CI generated the docs preview: https://69713--ocpdocs-pr.netlify.app

segevyos · 2024-01-01T14:40:03Z

/lgtm (CNV network QE)

orelmisan · 2024-01-01T15:08:45Z

/cc @sjhala-ccs

RamLavi

/lgtm

sjhala-ccs

A few suggestions, otherwise LGTM

sjhala-ccs · 2024-01-02T14:40:24Z

modules/virt-configuring-cluster-dpdk.adoc

@@ -94,10 +94,21 @@ $ oc get performanceprofiles.performance.openshift.io profile-1 -o=jsonpath='{.s
 $ oc patch hyperconverged kubevirt-hyperconverged -n {CNVNamespace} \
    --type='json' -p='[{"op": "add", "path": "/spec/defaultRuntimeClass", "value":"<runtimeclass-name>"}]'
 ----
+
+. In case your DPDK-enabled worker nodes are using SMT (Simultaneous multithreading), enable the `AlignCPUs` enabler by editing the `HyperConverged` custom resource (CR):


Suggested change

. In case your DPDK-enabled worker nodes are using SMT (Simultaneous multithreading), enable the `AlignCPUs` enabler by editing the `HyperConverged` custom resource (CR):

. If your DPDK-enabled compute nodes use Simultaneous multithreading (SMT), enable the `AlignCPUs` enabler by editing the `HyperConverged` CR:

Also changed the end of the previous instruction to match.

sjhala-ccs · 2024-01-02T14:43:21Z

modules/virt-configuring-cluster-dpdk.adoc

 +
 [NOTE]
 ====
 Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.
+
+Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using


Suggested change

Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using

By enabling `AlignCPUs`, you can request up to two additional dedicated CPUs to bring the total CPU count to an even parity when using

This can be a separate note after step 7

This is done automatically by KubeVirt, no user involvement required.

Okay, suggestion to change KubeVirt to {VirtProductName} which will render as "OpenShift Virtualization" in the published doc. Plus, a couple of minor edits.

Suggested change

Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using

Enabling `AlignCPUs` allows {VirtProductName} to request up to two additional dedicated CPUs to bring the total CPU count to an even parity when using

sjhala-ccs · 2024-01-02T14:50:39Z

modules/virt-configuring-cluster-dpdk.adoc

+----
+$ oc patch hyperconverged kubevirt-hyperconverged -n {CNVNamespace} \
+    --type='json' -p='[{"op": "replace", "path": "/spec/featureGates/alignCPUs", "value": true}]'
+----
 +
 [NOTE]
 ====
 Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.


Suggested change

Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.

Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.

I feel like this note should still be placed after step 6 because step 7 is conditional and might not apply to all users?

Separated the note to two distinct notes.

RamLavi

/lgtm

sjhala-ccs · 2024-01-04T14:17:05Z

modules/virt-configuring-cluster-dpdk.adoc

@@ -87,7 +87,7 @@ The compute nodes automatically restart after you apply the `MachineConfigPool`
 $ oc get performanceprofiles.performance.openshift.io profile-1 -o=jsonpath='{.status.runtimeClass}{"\n"}'
 ----

-. Set the previously obtained `RuntimeClass` name as the default container runtime class for the `virt-launcher` pods by editing the `HyperConverged` custom resource (CR):
+. Set the previously obtained `RuntimeClass` name as the default container runtime class for the `virt-launcher` pods by editing the `HyperConverged` CR:


Because this is the first instance of "CR", I would suggest keeping it as it was previously, spelling out custom resource (CR)

sjhala-ccs · 2024-01-04T14:21:06Z

modules/virt-configuring-cluster-dpdk.adoc

 +
 [NOTE]
 ====
 Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.
+
+Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using


Okay, suggestion to change KubeVirt to {VirtProductName} which will render as "OpenShift Virtualization" in the published doc. Plus, a couple of minor edits.

Suggested change

Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using

Enabling `AlignCPUs` allows {VirtProductName} to request up to two additional dedicated CPUs to bring the total CPU count to an even parity when using

In case the user's worker nodes have SMT [1] enabled, they will probably encounter CNV-31584 [2]. Add an instruction to enable the `AlignCPUs` enabler in HCO [3], so it will enable [4] KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using emulator thread isolation. [1] https://en.wikipedia.org/wiki/Simultaneous_multithreading [2] https://issues.redhat.com/browse/CNV-31584 [3] kubevirt/hyperconverged-cluster-operator#2695 [4] kubevirt/kubevirt#10872 Signed-off-by: Orel Misan <omisan@redhat.com>

sjhala-ccs · 2024-01-08T13:59:14Z

/retest

openshift-ci · 2024-01-08T14:06:55Z

@orelmisan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sjhala-ccs · 2024-01-08T15:02:47Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-01-08T15:05:14Z

@sjhala-ccs: new pull request created: #69903

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[virt] DPDK cluster config: Enable AlignCPUs

openshift-ci bot requested review from RamLavi and segevyos January 1, 2024 10:18

openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2024

openshift-ci bot requested a review from bell-lev January 1, 2024 10:19

orelmisan force-pushed the dpdk-cluster-config branch 4 times, most recently from 26bc838 to 737e416 Compare January 1, 2024 11:19

openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 1, 2024

orelmisan force-pushed the dpdk-cluster-config branch from 737e416 to dd05394 Compare January 1, 2024 11:22

openshift-ci bot requested a review from sjhala-ccs January 1, 2024 15:08

RamLavi approved these changes Jan 2, 2024

View reviewed changes

openshift-ci bot assigned RamLavi Jan 2, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024

sjhala-ccs added CNV Label for all CNV PRs branch/enterprise-4.15 labels Jan 2, 2024

sjhala-ccs added this to the Planned for 4.15 GA milestone Jan 2, 2024

sjhala-ccs changed the title ~~Virt, DPDK cluster config: Enable AlignCPUs~~ [virt] DPDK cluster config: Enable AlignCPUs Jan 2, 2024

sjhala-ccs reviewed Jan 2, 2024

View reviewed changes

sjhala-ccs added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 2, 2024

orelmisan force-pushed the dpdk-cluster-config branch from dd05394 to 23cb745 Compare January 3, 2024 11:10

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2024

RamLavi approved these changes Jan 3, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2024

sjhala-ccs reviewed Jan 4, 2024

View reviewed changes

orelmisan force-pushed the dpdk-cluster-config branch from 23cb745 to a184a6b Compare January 5, 2024 14:04

sjhala-ccs merged commit 779e98e into openshift:main Jan 8, 2024
2 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 8, 2024

[enterprise-4.15] [virt] DPDK cluster config: Enable AlignCPUs #69903

Merged

orelmisan deleted the dpdk-cluster-config branch January 8, 2024 15:45

aireilly pushed a commit to aireilly/openshift-docs that referenced this pull request Jan 8, 2024

Merge pull request openshift#69713 from orelmisan/dpdk-cluster-config

acd7106

[virt] DPDK cluster config: Enable AlignCPUs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[virt] DPDK cluster config: Enable AlignCPUs #69713

[virt] DPDK cluster config: Enable AlignCPUs #69713

orelmisan commented Jan 1, 2024 •

edited

orelmisan commented Jan 1, 2024

orelmisan commented Jan 1, 2024

ocpdocs-previewbot commented Jan 1, 2024 •

edited

segevyos commented Jan 1, 2024

orelmisan commented Jan 1, 2024

RamLavi left a comment

sjhala-ccs left a comment

sjhala-ccs Jan 2, 2024

orelmisan Jan 3, 2024

sjhala-ccs Jan 2, 2024

orelmisan Jan 3, 2024

sjhala-ccs Jan 4, 2024

orelmisan Jan 5, 2024

sjhala-ccs Jan 2, 2024

orelmisan Jan 3, 2024

RamLavi left a comment

sjhala-ccs Jan 4, 2024

orelmisan Jan 5, 2024

sjhala-ccs Jan 4, 2024

sjhala-ccs commented Jan 8, 2024

openshift-ci bot commented Jan 8, 2024

sjhala-ccs commented Jan 8, 2024

openshift-cherrypick-robot commented Jan 8, 2024

	. In case your DPDK-enabled worker nodes are using SMT (Simultaneous multithreading), enable the `AlignCPUs` enabler by editing the `HyperConverged` custom resource (CR):
	. If your DPDK-enabled compute nodes use Simultaneous multithreading (SMT), enable the `AlignCPUs` enabler by editing the `HyperConverged` CR:

	Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using
	By enabling `AlignCPUs`, you can request up to two additional dedicated CPUs to bring the total CPU count to an even parity when using

	Enabling `AlignCPUs`, allows KubeVirt to request up to two additional dedicated CPUs in order to complete the total CPU count to an even parity when using
	Enabling `AlignCPUs` allows {VirtProductName} to request up to two additional dedicated CPUs to bring the total CPU count to an even parity when using

	Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.
	Editing the `HyperConverged` CR changes a global setting that affects all VMs that are created after the change is applied.

[virt] DPDK cluster config: Enable AlignCPUs #69713

[virt] DPDK cluster config: Enable AlignCPUs #69713

Conversation

orelmisan commented Jan 1, 2024 • edited

orelmisan commented Jan 1, 2024

orelmisan commented Jan 1, 2024

ocpdocs-previewbot commented Jan 1, 2024 • edited

segevyos commented Jan 1, 2024

orelmisan commented Jan 1, 2024

RamLavi left a comment

Choose a reason for hiding this comment

sjhala-ccs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RamLavi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjhala-ccs commented Jan 8, 2024

openshift-ci bot commented Jan 8, 2024

sjhala-ccs commented Jan 8, 2024

openshift-cherrypick-robot commented Jan 8, 2024

orelmisan commented Jan 1, 2024 •

edited

ocpdocs-previewbot commented Jan 1, 2024 •

edited