Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP -3250 Updated1 - OADP ROSA docs xref mob docs #69714

Merged
merged 1 commit into from
Jan 17, 2024
Merged

OADP -3250 Updated1 - OADP ROSA docs xref mob docs #69714

merged 1 commit into from
Jan 17, 2024

Conversation

CarmiWisemon
Copy link
Contributor

@CarmiWisemon CarmiWisemon commented Jan 2, 2024 •
edited

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 2, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 2, 2024 •
edited

🤖 Wed Jan 17 12:55:35 - Prow CI generated the docs preview: https://69714--ocpdocs-pr.netlify.app

@CarmiWisemon CarmiWisemon changed the title WIP OADP -3250 Updated1 - OADP ROSA docs xref mob docs OADP -3250 Updated1 - OADP ROSA docs xref mob docs Jan 2, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2024
@CarmiWisemon CarmiWisemon force-pushed the oadp3250rosa branch 2 times, most recently from 72fa369 to a46c680 Compare January 4, 2024 09:16
@CarmiWisemon CarmiWisemon force-pushed the oadp3250rosa branch 2 times, most recently from b9328c6 to 11a0cc6 Compare January 8, 2024 16:26
@CarmiWisemon CarmiWisemon force-pushed the oadp3250rosa branch 3 times, most recently from 038cf28 to b3b31a9 Compare January 11, 2024 08:03
@CarmiWisemon
Copy link
Contributor Author

/label OADP
/label peer-review-needed

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 11, 2024
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 12, 2024
@CarmiWisemon CarmiWisemon force-pushed the oadp3250rosa branch 2 times, most recently from e7eeed6 to 4671334 Compare January 15, 2024 10:14
@CarmiWisemon
Copy link
Contributor Author

Left some comments, but nicely done with such a large chunk of content! Let me know if you have any questions about my feedback.

Also, I'm still relatively new to peer reviewing, so please wait until @adellape approves my review before implementing any feedback. Thanks!

@skopacz1 @adellape

Thank you for your feedback. I implemented your suggestions and another request that came from QE.
Thank you for your valuable suggestions and feedback.
Carmi

@anarnold97 @CarmiWisemon
Update - OADP ROSA docs and include MOB docs
9951179 
Signed-off-by: Andy Arnold <anarnold@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2024

@CarmiWisemon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@CarmiWisemon
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 17, 2024
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 17, 2024
@kcarmichael08 kcarmichael08 merged commit b0fbee6 into openshift:main Jan 17, 2024
2 checks passed
@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.12

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.13

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.14

@kcarmichael08
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #70412

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jan 17, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #70413

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #70414

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@kcarmichael08: new pull request created: #70416

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@kcarmichael08 kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adellape adellape adellape left review comments

@PrasadJoshi12 PrasadJoshi12 PrasadJoshi12 left review comments

@skopacz1 skopacz1 skopacz1 left review comments

@kaovilai kaovilai kaovilai approved these changes

Assignees
No one assigned
Labels
OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@CarmiWisemon @ocpdocs-previewbot @skopacz1 @kcarmichael08 @openshift-cherrypick-robot @adellape @kaovilai @PrasadJoshi12 @anarnold97