OCPBUGS#24683: Added Role and RoleBinding objects to enable monitoring #69893
Conversation
openshift-ci
bot
added
the
size/M
|
🤖 Thu Jan 18 12:31:35 - Prow CI generated the docs preview: https://69893--ocpdocs-pr.netlify.app |
snarayan-redhat
changed the title
|
/lgtm |
snarayan-redhat
force-pushed
the
OCPBUGS-24683
branch
from
a7070b1
to
3b49e75
Compare
|
/lgtm |
|
/lgtm cancel |
I had discussed this with @swghosh. He confirmed that we would need this step. @swghosh any inputs? |
|
@xingxingxia Would you prefer both scenarios of monitoring
During discussion with @snarayan-redhat, it came up that it is desirable to document the most useful use case and went ahead that cert-manager would likely be most suitable as a in-cluster component than a user workload, hence this change was proposed with this behaviour. |
@swghosh my previous comment #69893 (comment) is exactly as same as your thought, i.e. remove the "steps to setup monitoring for user-defined workloads" which is documented as "Enable monitoring for user-defined projects. See Enabling monitoring for user-defined projects for instructions" and Additional resources "Enabling monitoring for user-defined projects". It is not yet removed. |
@swghosh IIUC, @xingxingxia correct me if I am wrong, for this documented scenario, the bug suggested that we need not go for "Enabling monitoring for user-defined projects" in case we are retaining the namespace and adding Role and RoleBinding objects. However, as per our discussion, you suggested that only addition of the objects is required and need not remove Step 2. |
|
Hi @snarayan-redhat, could you also remove the first link("Enabling monitoring for user-defined projects") in "Additional resources" part?
|
Done |
|
/lgtm Thanks! |
snarayan-redhat
force-pushed
the
OCPBUGS-24683
branch
from
e5c0337
to
087d84c
Compare
snarayan-redhat
added
the
peer-review-needed
|
LGTM, thx! |
kcarmichael08
added
peer-review-in-progress
kcarmichael08
added
peer-review-done
|
New changes are detected. LGTM label has been removed. |
snarayan-redhat
force-pushed
the
OCPBUGS-24683
branch
from
5537671
to
b9571a1
Compare
|
@snarayan-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.12 |
|
@snarayan-redhat: new pull request created: #70476 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
@snarayan-redhat: new pull request created: #70477 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #70478 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@snarayan-redhat: new pull request created: #70479 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OCPBUGS-24683
Link to docs preview: https://69893--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/cert_manager_operator/cert-manager-monitoring#cert-manager-enable-metrics_cert-manager-monitoring
QE review: