Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19883: Move reboot warning in "Replacing an unhealthy etcd member" #70035

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

kowen-rh
Copy link
Contributor

@kowen-rh kowen-rh commented Jan 10, 2024

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2024
@openshift-ci-robot
Copy link

@kowen-rh: This pull request references Jira Issue OCPBUGS-19883, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19883

Link to docs preview:
TBD

QE review:

  • QE has approved this change.

Additional information:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2024
@kowen-rh kowen-rh changed the title OCPBUGS-19883: Move reboot warning in "Replacing an unhealthy etcd member" OCPBUGS#19883: Move reboot warning in "Replacing an unhealthy etcd member" Jan 10, 2024
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2024
@openshift-ci-robot
Copy link

@kowen-rh: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19883

Link to docs preview:
TBD

QE review:

  • QE has approved this change.

Additional information:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kowen-rh kowen-rh changed the title OCPBUGS#19883: Move reboot warning in "Replacing an unhealthy etcd member" OCPBUGS-19883: Move reboot warning in "Replacing an unhealthy etcd member" Jan 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci-robot
Copy link

@kowen-rh: This pull request references Jira Issue OCPBUGS-19883, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19883

Link to docs preview:
TBD

QE review:

  • QE has approved this change.

Additional information:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 10, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 10, 2024

🤖 Wed Jan 10 18:05:01 - Prow CI generated the docs preview: https://70035--ocpdocs-pr.netlify.app

@tjungblu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
@kowen-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 10, 2024
@tmalove
Copy link
Contributor

tmalove commented Jan 10, 2024

/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 10, 2024
+
[NOTE]
====
etcd cannot tolerate any additional member failure when running with two members. Restarting either of the two remaining members breaks quorum and causes downtime in your cluster. The quorum guard protects etcd from restarts due to configuration changes that could cause such downtime, which is why it must be disabled to complete this procedure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
etcd cannot tolerate any additional member failure when running with two members. Restarting either of the two remaining members breaks quorum and causes downtime in your cluster. The quorum guard protects etcd from restarts due to configuration changes that could cause such downtime, which is why it must be disabled to complete this procedure.
etcd cannot tolerate any additional member failure when running with two members. Restarting either remaining member breaks the quorum and causes downtime in your cluster. The quorum guard protects etcd from restarts due to configuration changes that could cause downtime, so it must be disabled to complete this procedure.

Suggestion: Minimalism - See SSG https://redhat-documentation.github.io/supplementary-style-guide/#minimalism

@tmalove
Copy link
Contributor

tmalove commented Jan 10, 2024

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 10, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2024
Copy link

openshift-ci bot commented Jan 10, 2024

New changes are detected. LGTM label has been removed.

@kowen-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 10, 2024
Copy link

openshift-ci bot commented Jan 10, 2024

@kowen-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bscott-rh bscott-rh added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 10, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh added branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 10, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone Jan 10, 2024
@bscott-rh bscott-rh merged commit 42057a1 into openshift:main Jan 10, 2024
2 checks passed
@openshift-ci-robot
Copy link

@kowen-rh: Jira Issue OCPBUGS-19883 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.11+

Issue:
https://issues.redhat.com/browse/OCPBUGS-19883

Link to docs preview:
https://70035--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/control_plane_backup_and_restore/replacing-unhealthy-etcd-member#restore-replace-stopped-etcd-member_replacing-unhealthy-etcd-member

QE review:

  • QE has approved this change.

Additional information:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #70062

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #70063

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #70064

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #70066

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@bscott-rh: new pull request created: #70067

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kowen-rh kowen-rh deleted the ocpbugs-19883 branch January 18, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants