Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-3183: Doc improvements as CherryPick for 4.13 #70138

Merged
merged 1 commit into from
Jan 12, 2024
Merged

OADP-3183: Doc improvements as CherryPick for 4.13 #70138

merged 1 commit into from
Jan 12, 2024

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Jan 11, 2024 •
edited

Jira

This PR is a cherry pick for 4.13

For OCP 4.13

  • OCP 4.13 → branch/enterprise-4.13

QE review

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2024 •
edited by openshift-ci bot

@anarnold97: This pull request references OADP-3183 which is a valid jira issue.

In response to this:

Jira

For OCP 4.13

  • OCP 4.13 → branch/enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 11, 2024
@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Jan 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 11, 2024 •
edited

🤖 Fri Jan 12 11:14:22 - Prow CI generated the docs preview: https://70138--ocpdocs-pr.netlify.app

@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 11, 2024 •
edited by openshift-ci bot

@anarnold97: This pull request references OADP-3183 which is a valid jira issue.

In response to this:

Jira

This PR is a cherry pick for 4.13

For OCP 4.13

  • OCP 4.13 → branch/enterprise-4.13

QE review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 12, 2024
xenolinux
xenolinux reviewed Jan 12, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions to consider otherwise LGTM

Can you please provide the preview link?

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

modules/oadp-installing-dpa-1-2-and-earlier.adoc Outdated Show resolved Hide resolved
modules/oadp-installing-dpa-1-2-and-earlier.adoc Outdated Show resolved Hide resolved
modules/oadp-installing-dpa-1-2-and-earlier.adoc Outdated Show resolved Hide resolved
modules/oadp-installing-dpa-1-3.adoc Outdated Show resolved Hide resolved
modules/oadp-installing-dpa-1-3.adoc Outdated
$ oc get backupStorageLocation -n openshift-adp
----
.Example output
[source,yaml]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It says [source,yaml] but the output is not in yaml format. Should [source,yaml] be [source,terminal]?

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 12, 2024
@anarnold97 anarnold97 force-pushed the OADP-3183-Doc-improvements-CP-4-13 branch from e5d686b to d0aa6c6 Compare January 12, 2024 11:03
@anarnold97
OADP-3183: Doc improvements as CherryPick for 4.13
77b0a68 
Signed-off-by: Andy Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the OADP-3183-Doc-improvements-CP-4-13 branch from 92d0f62 to 77b0a68 Compare January 12, 2024 11:09
@anarnold97
Copy link
Contributor Author

Thanks @xenolinux - good spots as always

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 12, 2024

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bscott-rh bscott-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.13 labels Jan 12, 2024
@bscott-rh bscott-rh added this to the Continuous Release milestone Jan 12, 2024
@bscott-rh
Copy link
Contributor

Merge review LGTM.

@bscott-rh bscott-rh merged commit 9f15671 into openshift:enterprise-4.13 Jan 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.13 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anarnold97 @openshift-ci-robot @ocpdocs-previewbot @xenolinux @bscott-rh