Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-723 - Logging 5.7.10 Release Notes #70382

Merged
merged 1 commit into from Jan 17, 2024
Merged

OBSDOCS-723 - Logging 5.7.10 Release Notes #70382

merged 1 commit into from Jan 17, 2024

Conversation

libander
Copy link
Contributor

@libander libander commented Jan 16, 2024 •
edited

Version(s): 4.11. 4.12, 4.13, 4.14

Issue: OBSDOCS-723

Link to docs preview:

QE review: @anpingli / @QiaolingTang / @kabirbhartiRH

  • QE has approved this change.

Additional information: CPs to be created after review.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 16, 2024 •
edited

🤖 Wed Jan 17 16:00:17 - Prow CI generated the docs preview: https://70382--ocpdocs-pr.netlify.app

@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2024
@libander
Copy link
Contributor Author

SME review please: @periklis / @jcantrill / @xperimental / @cahartma

@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2024
@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
skrthomas
skrthomas reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One teeny comment. LGTM

modules/logging-release-notes-5-7-10.adoc Outdated Show resolved Hide resolved
@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2024
periklis
periklis reviewed Jan 17, 2024
View reviewed changes
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 17, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 17, 2024
@skrthomas skrthomas merged commit d9b3859 into openshift:enterprise-4.14 Jan 17, 2024
2 checks passed
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.11

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.12

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #70433

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #70434

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@openshift-cherrypick-robot
Copy link

@skrthomas: new pull request created: #70435

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2024
Merged
@skrthomas skrthomas added this to the Continuous Release milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis requested changes

@skrthomas skrthomas skrthomas left review comments

Assignees

@anpingli anpingli

Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@libander @ocpdocs-previewbot @anpingli @skrthomas @openshift-cherrypick-robot @periklis