Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-722 - Logging 5.6.15 Release Notes #70383

Merged
merged 1 commit into from Jan 18, 2024

Conversation

libander
Copy link
Contributor

@libander libander commented Jan 16, 2024

Version(s): 4.11. 4.12, 4.13

Issue: OBSDOCS-722

Link to docs preview: https://70383--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/logging_release_notes/logging-5-6-release-notes

QE review: @anpingli / @QiaolingTang / @kabirbhartiRH

  • QE has approved this change.

Additional information: CPs to be created after review.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2024
@libander
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 16, 2024
@libander
Copy link
Contributor Author

SME review please: @periklis / @jcantrill / @xperimental / @cahartma

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 16, 2024

🤖 Wed Jan 17 15:18:19 - Prow CI generated the docs preview: https://70383--ocpdocs-pr.netlify.app

Copy link

openshift-ci bot commented Jan 17, 2024

@libander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anpingli
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
Copy link

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@libander
Copy link
Contributor Author

/cherry-pick enterprise-4.12

@openshift-cherrypick-robot

@libander: once the present PR merges, I will cherry-pick it on top of enterprise-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@libander
Copy link
Contributor Author

/cherry-pick enterprise-4.11

@openshift-cherrypick-robot

@libander: once the present PR merges, I will cherry-pick it on top of enterprise-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 17, 2024
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@skrthomas
Copy link
Contributor

I saw your reply on my other bug fix comment, and I totally get ya. Fine by me to keep it consistent w/ other titles.

@skrthomas skrthomas added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 17, 2024
@kalexand-rh
Copy link
Contributor

For whoever picks up the merge review, this change is straightforward enough that you can use the CP bot to create the PRs for 4.12 and 4.11.

@libander
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 18, 2024
@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.11 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 18, 2024
@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@skrthomas: once the present PR merges, I will cherry-pick it on top of enterprise-4.11 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas
Copy link
Contributor

/cherrypick enterprise-4.12

@openshift-cherrypick-robot

@skrthomas: once the present PR merges, I will cherry-pick it on top of enterprise-4.12 in a new PR and assign it to you.

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skrthomas skrthomas merged commit e058b89 into openshift:enterprise-4.13 Jan 18, 2024
2 checks passed
@openshift-cherrypick-robot

@libander: new pull request created: #70541

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@libander: new pull request created: #70542

In response to this:

/cherry-pick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.11 branch/enterprise-4.12 branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants