Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-26200: Removed the lbType from AWS Sample YAML #70556

Merged
merged 1 commit into from
Jan 26, 2024
Merged

OCPBUGS-26200: Removed the lbType from AWS Sample YAML #70556

merged 1 commit into from
Jan 26, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Jan 19, 2024 •
edited

Version(s):
4.15 - 4.12

Issue:
OCPBUGS-26200

Link to docs preview:

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 19, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-26200, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2024
@ocpdocs-previewbot
Copy link

🤖 Fri Jan 19 10:07:32 - Prow CI generated the docs preview: https://70556--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 19, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@r4f4
Copy link

r4f4 commented Jan 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2024
@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 19, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 19, 2024
@kcarmichael08
Copy link
Contributor

LGTM!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 19, 2024
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Jan 19, 2024
@yunjiang29
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-26200, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.15 - 4.12

Issue:
OCPBUGS-26200

Link to docs preview:

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 26, 2024
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jan 26, 2024
@stevsmit
Copy link
Member

lgtm

@stevsmit stevsmit merged commit 49474e3 into openshift:main Jan 26, 2024
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-26200 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.15 - 4.12

Issue:
OCPBUGS-26200

Link to docs preview:

SME review:

  • SME has approved this change.

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.12

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.13

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.14

@stevsmit
Copy link
Member

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #70861

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #70862

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #70863

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Merged
@openshift-cherrypick-robot
Copy link

@stevsmit: new pull request created: #70864

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@r4f4 r4f4

@yunjiang29 yunjiang29

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @r4f4 @kcarmichael08 @yunjiang29 @stevsmit @openshift-cherrypick-robot