OADP - 3343 Update Using the must-gather tool #70665

CarmiWisemon · 2024-01-23T09:27:15Z

OADP 1.3.1

OCP 4.13+

Resolves - https://issues.redhat.com/browse/OADP-3343

Deploy preview - https://70665--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/troubleshooting#migration-using-must-gather_oadp-troubleshooting

ocpdocs-previewbot · 2024-01-23T09:30:56Z

🤖 Sun Feb 04 12:37:23 - Prow CI generated the docs preview: https://70665--ocpdocs-pr.netlify.app

weshayutin

thanks!
/LGTM

modules/migration-using-must-gather.adoc

PrasadJoshi12 · 2024-01-24T07:48:56Z

@CarmiWisemon I think PR is missing below flag. This flag is needed when customer has configured s3url with prefix https:// and insecureSkipTLSVerify: true flag set on DPA
oc adm must-gather --image=registry.access.redhat.com/oadp/oadp-mustgather-rhel9:1.3.0-138 – /usr/bin/gather_without_tls true

CarmiWisemon · 2024-01-24T14:45:56Z

@CarmiWisemon I think PR is missing below flag. This flag is needed when customer has configured s3url with prefix https:// and insecureSkipTLSVerify: true flag set on DPA oc adm must-gather --image=registry.access.redhat.com/oadp/oadp-mustgather-rhel9:1.3.0-138 – /usr/bin/gather_without_tls true

@PrasadJoshi12

Where in the document and how should it be included?

PrasadJoshi12 · 2024-01-25T09:14:30Z

@CarmiWisemon I think PR is missing below flag. This flag is needed when customer has configured s3url with prefix https:// and insecureSkipTLSVerify: true flag set on DPA oc adm must-gather --image=registry.access.redhat.com/oadp/oadp-mustgather-rhel9:1.3.0-138 – /usr/bin/gather_without_tls true

@PrasadJoshi12

Where in the document and how should it be included?

Maybe we can add this instructions under this section "Combining options when using the must-gather tool".

If DPA is configured with s3Url and having insecureSkipTLS flat set to true in that case it will not collect the necessary logs due to missing CA cert. In order to collect those logs execute must gather command with below option.
oc adm must-gather --image=registry.access.redhat.com/oadp/oadp-mustgather-rhel9:1.3.0-138 – /usr/bin/gather_without_tls true

modules/migration-combining-must-gather.adoc

CarmiWisemon · 2024-01-30T10:08:15Z

/label OADP
/label peer-review-needed

CarmiWisemon · 2024-02-01T14:19:23Z

/label merge-review-needed

opayne1

Just a couple things to consider before merging. Just ping me when you are ready!

opayne1 · 2024-02-01T21:00:52Z

modules/migration-combining-must-gather.adoc

@@ -18,3 +18,10 @@ The only other variables that you can specify this way are the following:

 * `logs_since`, with a default value of `72h`
 * `request_timeout`, with a default value of `0s`
+
+If DataProtectionApplication (DPA) is configured with `s3Url` and `insecureSkipTLS: true`, the CR does not collect the necessary logs because of a missing CA certificate. To collect those logs, run the `must-gather` command with the following option:


I haven't seen DataProtectionApplication (DPA) written that way in the docs, but I have seen it with backticks which would make sense to me. Just wanted to check on this.

Suggested change

If DataProtectionApplication (DPA) is configured with `s3Url` and `insecureSkipTLS: true`, the CR does not collect the necessary logs because of a missing CA certificate. To collect those logs, run the `must-gather` command with the following option:

If `DataProtectionApplication` custom resource (CR) is configured with `s3Url` and `insecureSkipTLS: true`, the CR does not collect the necessary logs because of a missing CA certificate. To collect those logs, run the `must-gather` command with the following option:

opayne1 · 2024-02-01T21:02:08Z

modules/migration-using-must-gather.adoc

@@ -28,6 +28,8 @@ endif::[]

 * You must be logged in to the {product-title} cluster as a user with the `cluster-admin` role.
 * You must have the OpenShift CLI (`oc`) installed.
+* For use with OADP 1.2 you must use {op-system-base-full} 8.x.


To keep your bullets consistent consider:

Suggested change

* For use with OADP 1.2 you must use {op-system-base-full} 8.x.

* You must use {op-system-base-full} 8.x with OADP 1.2.

opayne1 · 2024-02-01T21:02:40Z

modules/migration-using-must-gather.adoc

@@ -28,6 +28,8 @@ endif::[]

 * You must be logged in to the {product-title} cluster as a user with the `cluster-admin` role.
 * You must have the OpenShift CLI (`oc`) installed.
+* For use with OADP 1.2 you must use {op-system-base-full} 8.x.
+* For use with OADP 1.3 you must use {op-system-base-full} {op-system-version}.


Same for this one:

Suggested change

* For use with OADP 1.3 you must use {op-system-base-full} {op-system-version}.

* You must use {op-system-base-full} {op-system-version} with OADP 1.3 y.

opayne1 · 2024-02-01T21:02:52Z

modules/migration-using-must-gather.adoc

@@ -40,10 +42,18 @@ endif::[]
 ifdef::oadp-troubleshooting[]
 * Full `must-gather` data collection, including Prometheus metrics:
 endif::[]
+.. For OADP 1.2 use the following command:


Suggested change

.. For OADP 1.2 use the following command:

.. For OADP 1.2, use the following command:

opayne1 · 2024-02-01T21:03:04Z

modules/migration-using-must-gather.adoc

+oc adm must-gather --image=registry.redhat.io/oadp/oadp-mustgather-rhel8:v1.2
+----
+
+.. For OADP 1.3 use the following command:


Suggested change

.. For OADP 1.3 use the following command:

.. For OADP 1.3, use the following command:

opayne1 · 2024-02-01T21:03:23Z

modules/migration-using-must-gather.adoc

@@ -73,12 +83,17 @@ endif::[]
 ifdef::oadp-troubleshooting[]
 * Prometheus metrics data dump:
 endif::[]
+.. For OADP 1.2 use the following command:


Suggested change

.. For OADP 1.2 use the following command:

.. For OADP 1.2, use the following command:

opayne1 · 2024-02-01T21:03:33Z

modules/migration-using-must-gather.adoc

 ----
+.. For OADP 1.3 use the following command:


Suggested change

.. For OADP 1.3 use the following command:

.. For OADP 1.3, use the following command:

openshift-ci · 2024-02-04T12:39:36Z

@CarmiWisemon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

CarmiWisemon · 2024-02-04T13:32:52Z

Just a couple things to consider before merging. Just ping me when you are ready!

@opayne1
Thank you for your feedback.
I made the changes you requested.
Please merge the PR.
Thank you!!!
Carmi

opayne1

/lgtm

opayne1 · 2024-02-05T12:30:15Z

/cherrypick enterprise-4.13

opayne1 · 2024-02-05T12:30:23Z

/cherrypick enterprise-4.14

opayne1 · 2024-02-05T12:30:29Z

/cherrypick enterprise-4.15

openshift-cherrypick-robot · 2024-02-05T12:33:42Z

@opayne1: new pull request created: #71166

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2024-02-05T12:33:46Z

@opayne1: new pull request created: #71167

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2024-02-05T12:33:49Z

@opayne1: new pull request created: #71168

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2024

weshayutin approved these changes Jan 23, 2024

View reviewed changes

openshift-ci bot assigned weshayutin Jan 23, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024

stillalearner reviewed Jan 24, 2024

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

stillalearner reviewed Jan 24, 2024

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

stillalearner reviewed Jan 24, 2024

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

stillalearner reviewed Jan 24, 2024

View reviewed changes

modules/migration-using-must-gather.adoc Outdated Show resolved Hide resolved

CarmiWisemon force-pushed the oadp3343-mustgather branch from 8f2bb94 to db084ee Compare January 24, 2024 14:35

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024

CarmiWisemon force-pushed the oadp3343-mustgather branch from 8a4881f to 6b4e1d5 Compare January 24, 2024 14:50

CarmiWisemon force-pushed the oadp3343-mustgather branch from 6b4e1d5 to 2845bcb Compare January 25, 2024 09:31

openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 25, 2024

CarmiWisemon commented Jan 25, 2024

View reviewed changes

modules/migration-combining-must-gather.adoc Show resolved Hide resolved

PrasadJoshi12 reviewed Jan 25, 2024

View reviewed changes

modules/migration-combining-must-gather.adoc Outdated Show resolved Hide resolved

CarmiWisemon force-pushed the oadp3343-mustgather branch from 4a17a32 to d3f8808 Compare January 25, 2024 12:05

PrasadJoshi12 reviewed Jan 29, 2024

View reviewed changes

modules/migration-combining-must-gather.adoc Outdated Show resolved Hide resolved

PrasadJoshi12 reviewed Jan 29, 2024

View reviewed changes

modules/migration-combining-must-gather.adoc Outdated Show resolved Hide resolved

CarmiWisemon force-pushed the oadp3343-mustgather branch 4 times, most recently from b9135f9 to bcfde28 Compare January 30, 2024 09:58

openshift-ci bot added OADP Label for all OADP PRs peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 30, 2024

openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 1, 2024

CarmiWisemon force-pushed the oadp3343-mustgather branch from 5d92705 to 425f256 Compare February 1, 2024 14:10

openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 1, 2024

opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 1, 2024

opayne1 added this to the Continuous Release milestone Feb 1, 2024

opayne1 added branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 labels Feb 1, 2024

opayne1 reviewed Feb 1, 2024

View reviewed changes

CarmiWisemon force-pushed the oadp3343-mustgather branch from 425f256 to af0d122 Compare February 4, 2024 11:57

OADP - 3343 Update Using the must-gather tool

a42e6c7

CarmiWisemon force-pushed the oadp3343-mustgather branch from a2d30f1 to a42e6c7 Compare February 4, 2024 12:32

opayne1 reviewed Feb 5, 2024

View reviewed changes

opayne1 merged commit 64373c0 into openshift:main Feb 5, 2024
2 checks passed

openshift-ci bot assigned opayne1 Feb 5, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2024

openshift-cherrypick-robot mentioned this pull request Feb 5, 2024

[enterprise-4.14] OADP - 3343 Update Using the must-gather tool #71166

Merged

openshift-cherrypick-robot mentioned this pull request Feb 5, 2024

[enterprise-4.15] OADP - 3343 Update Using the must-gather tool #71167

Merged

openshift-cherrypick-robot mentioned this pull request Feb 5, 2024

[enterprise-4.13] OADP - 3343 Update Using the must-gather tool #71168

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OADP - 3343 Update Using the must-gather tool #70665

OADP - 3343 Update Using the must-gather tool #70665

CarmiWisemon commented Jan 23, 2024 •

edited

ocpdocs-previewbot commented Jan 23, 2024 •

edited

weshayutin left a comment

PrasadJoshi12 commented Jan 24, 2024

CarmiWisemon commented Jan 24, 2024

PrasadJoshi12 commented Jan 25, 2024

CarmiWisemon commented Jan 30, 2024

CarmiWisemon commented Feb 1, 2024

opayne1 left a comment

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

opayne1 Feb 1, 2024

openshift-ci bot commented Feb 4, 2024

CarmiWisemon commented Feb 4, 2024

opayne1 left a comment

opayne1 commented Feb 5, 2024

opayne1 commented Feb 5, 2024

opayne1 commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

	If DataProtectionApplication (DPA) is configured with `s3Url` and `insecureSkipTLS: true`, the CR does not collect the necessary logs because of a missing CA certificate. To collect those logs, run the `must-gather` command with the following option:
	If `DataProtectionApplication` custom resource (CR) is configured with `s3Url` and `insecureSkipTLS: true`, the CR does not collect the necessary logs because of a missing CA certificate. To collect those logs, run the `must-gather` command with the following option:

	* For use with OADP 1.2 you must use {op-system-base-full} 8.x.
	* You must use {op-system-base-full} 8.x with OADP 1.2.

	* For use with OADP 1.3 you must use {op-system-base-full} {op-system-version}.
	* You must use {op-system-base-full} {op-system-version} with OADP 1.3 y.

	.. For OADP 1.2 use the following command:
	.. For OADP 1.2, use the following command:

	.. For OADP 1.3 use the following command:
	.. For OADP 1.3, use the following command:

OADP - 3343 Update Using the must-gather tool #70665

OADP - 3343 Update Using the must-gather tool #70665

Conversation

CarmiWisemon commented Jan 23, 2024 • edited

ocpdocs-previewbot commented Jan 23, 2024 • edited

weshayutin left a comment

Choose a reason for hiding this comment

PrasadJoshi12 commented Jan 24, 2024

CarmiWisemon commented Jan 24, 2024

PrasadJoshi12 commented Jan 25, 2024

CarmiWisemon commented Jan 30, 2024

CarmiWisemon commented Feb 1, 2024

opayne1 left a comment

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

opayne1 Feb 1, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Feb 4, 2024

CarmiWisemon commented Feb 4, 2024

opayne1 left a comment

Choose a reason for hiding this comment

opayne1 commented Feb 5, 2024

opayne1 commented Feb 5, 2024

opayne1 commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

openshift-cherrypick-robot commented Feb 5, 2024

CarmiWisemon commented Jan 23, 2024 •

edited

ocpdocs-previewbot commented Jan 23, 2024 •

edited