Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-764: Distributed tracing 3.1 release notes and content rearrangement (from multiple pages into a single page) #70943

Closed
wants to merge 1 commit into from
Closed

OBSDOCS-764: Distributed tracing 3.1 release notes and content rearrangement (from multiple pages into a single page) #70943

wants to merge 1 commit into from

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Jan 29, 2024 •
edited

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-764

Link to docs preview:

💡 Please note that the XXL size of this PR is misleading: content from roughly twenty pages was collected into two pages, which shows up like a lot of new content, which is in fact not the case.

This PR results in the four following pages:

New content:

Reorganized, currently published content, which does not need to be reviewed, except for the lines in _topic_maps/_topic_map.yml and correct heading levels in two other files:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2024 •
edited by openshift-ci bot

@max-cx: This pull request references OBSDOCS-764 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

4.15, 4.14, 4.13, 4.12, 4.11

Issue:

https://issues.redhat.com/browse/OBSDOCS-764

Link to docs preview:

QE review:

  • QE has approved this change.
  • No need for QE approval because this is just to move content around pages

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2024
@max-cx
Copy link
Contributor Author

max-cx commented Jan 29, 2024

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 29, 2024 •
edited

🤖 Thu Feb 22 16:49:51 - Prow CI generated the docs preview: https://70943--ocpdocs-pr.netlify.app

@max-cx
Copy link
Contributor Author

max-cx commented Jan 29, 2024

/retest

1 similar comment
@max-cx
Copy link
Contributor Author

max-cx commented Jan 30, 2024

/retest

@max-cx
Copy link
Contributor Author

max-cx commented Jan 30, 2024

/retest

@max-cx max-cx force-pushed the OBSDOCS-764 branch 3 times, most recently from 4cbe552 to a4784c1 Compare January 31, 2024 09:34
@aireilly
Copy link
Contributor

/retest

@aireilly aireilly marked this pull request as ready for review January 31, 2024 13:05
@aireilly
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 31, 2024
@max-cx
Copy link
Contributor Author

max-cx commented Jan 31, 2024

/test validate-asciidoc

@max-cx max-cx marked this pull request as draft February 1, 2024 17:26
@max-cx max-cx force-pushed the OBSDOCS-764 branch 2 times, most recently from 68cc66e to 2053569 Compare February 8, 2024 16:19
@max-cx
Copy link
Contributor Author

max-cx commented Feb 8, 2024

/test all

@max-cx
Copy link
Contributor Author

max-cx commented Feb 8, 2024

/retest

@max-cx
Copy link
Contributor Author

max-cx commented Feb 8, 2024

/test all

@max-cx max-cx force-pushed the OBSDOCS-764 branch 3 times, most recently from ffef1bf to 737e0f5 Compare February 9, 2024 14:48
@gwynnemonahan
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 19, 2024
@gwynnemonahan
Copy link
Contributor

Hey @max-cx ,

Left a couple of comments related to guidance on phrasing bug fixes for 3.1.

I'm still in training, so @abrennan89 also needs to review.

abrennan89
abrennan89 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments @max-cx - good work, just a few fixes needed.
Let me know if I've missed any pages, I think I covered everything you requested reviews for in the description.

distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc Outdated Show resolved Hide resolved
@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 21, 2024
@abrennan89 abrennan89 added this to the Continuous Release milestone Feb 21, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@max-cx max-cx force-pushed the OBSDOCS-764 branch 2 times, most recently from 52ec022 to 28aaed5 Compare February 22, 2024 15:52
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@max-cx
OBSDOCS-764
3594ca9 
 Changes to be committed:
	modified:   _attributes/common-attributes.adoc
	modified:   _topic_maps/_topic_map.yml
	modified:   distr_tracing/distr_tracing_arch/distr-tracing-architecture.adoc
	modified:   distr_tracing/distr_tracing_jaeger/distr-tracing-jaeger-configuring.adoc
	modified:   distr_tracing/distr_tracing_jaeger/distr-tracing-jaeger-installing.adoc
	modified:   distr_tracing/distr_tracing_jaeger/distr-tracing-jaeger-removing.adoc
	modified:   distr_tracing/distr_tracing_jaeger/distr-tracing-jaeger-updating.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-0.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-1.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-2.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-3.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-4.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-5.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-6.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-7.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-8.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-9-1.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-9-2.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-2-9.adoc
	deleted:    distr_tracing/distr_tracing_rn/distr-tracing-rn-3-0.adoc
	new file:   distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1.adoc
	new file:   distr_tracing/distr_tracing_rn/distr-tracing-rn-past-releases.adoc
	modified:   modules/distr-tracing-product-overview.adoc
	new file:   modules/otel-product-overview.adoc
	modified:   otel/otel-migrating.adoc
	deleted:    otel/otel-release-notes.adoc
	new file:   otel/otel_rn/_attributes
	new file:   otel/otel_rn/images
	new file:   otel/otel_rn/modules
	new file:   otel/otel_rn/otel-rn-3.1.adoc
	new file:   otel/otel_rn/otel-rn-past-releases.adoc
	new file:   otel/otel_rn/snippets
	modified:   welcome/index.adoc
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 22, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@max-cx max-cx mentioned this pull request Feb 22, 2024
Merged
1 task
@max-cx
Copy link
Contributor Author

max-cx commented Feb 22, 2024

Closing this PR because its commit has been cherry-picked into #72079.

@max-cx max-cx closed this Feb 22, 2024
This was referenced Feb 26, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay left review comments

@gwynnemonahan gwynnemonahan gwynnemonahan left review comments

@abrennan89 abrennan89 abrennan89 left review comments

@aireilly aireilly aireilly left review comments

@IshwarKanse IshwarKanse IshwarKanse approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@max-cx @openshift-ci-robot @ocpdocs-previewbot @aireilly @kalexand-rh @gwynnemonahan @pavolloffay @IshwarKanse @abrennan89 @openshift-merge-robot