Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHDEVDOCS-5860: Changing the text of the button #71329

Merged
merged 1 commit into from
Mar 5, 2024
Merged

RHDEVDOCS-5860: Changing the text of the button #71329

merged 1 commit into from
Mar 5, 2024

Conversation

shipsing
Copy link
Contributor

@shipsing shipsing commented Feb 8, 2024

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-5860 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 8, 2024 •
edited

🤖 Updated build preview is available at:
https://71329--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/37691

@Dhruv-Soni11
Copy link
Contributor

Dhruv-Soni11 commented Feb 8, 2024 •
edited

Version(s):
GitOps 1.11
Versions for cherry-picking
GitOps 1.8, 1.9, 1.10
Issue:
https://issues.redhat.com/browse/RHDEVDOCS-5860
Link to docs preview:
https://71329--docspreview.netlify.app/openshift-gitops/latest/argocd_instance/setting-up-argocd-instance
QE review:
@varshab1210
SME review:
@reginapizza

  • QE has approved this change.
    Initial peer review:
    @joaedwar
    Peer review:
    Additional information:

@Dhruv-Soni11 Dhruv-Soni11 mentioned this pull request Feb 8, 2024
Closed
1 task
@shipsing shipsing marked this pull request as draft February 8, 2024 09:00
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@shipsing shipsing changed the title RHDEVDOCS-5860: Changing the text of the button WIP: RHDEVDOCS-5860: Changing the text of the button Feb 8, 2024
@shipsing shipsing marked this pull request as ready for review February 8, 2024 10:58
@shipsing shipsing changed the title WIP: RHDEVDOCS-5860: Changing the text of the button RHDEVDOCS-5860: Changing the text of the button Feb 8, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@Dhruv-Soni11
Copy link
Contributor

Dhruv-Soni11 commented Feb 8, 2024 •
edited

/label peer-review-needed

buildbricks
buildbricks approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@buildbricks buildbricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@varshab1210
Copy link

LGTM, thanks

eromanova97
eromanova97 reviewed Feb 27, 2024
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I have just one minor comment, I commented more on this procedure in my review here: #71605 (comment)
Thank you!

modules/gitops-argo-cd-installation.adoc Outdated Show resolved Hide resolved
buildbricks
buildbricks approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@buildbricks buildbricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one suggestion based on the IBM style guide

@Dhruv-Soni11
Copy link
Contributor

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2024
mletalie
mletalie reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 1, 2024
mletalie
mletalie reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done
/lgtm

@openshift-ci openshift-ci bot added the peer-review-done Signifies that the peer review team has reviewed this PR label Mar 1, 2024
@openshift-ci openshift-ci bot removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@mletalie
Copy link
Contributor

mletalie commented Mar 1, 2024

Hello @shipsing,
LGTM. The only thing I would suggest is checking the "QE has approved this change" box, as it looks like that is the case. Thanks!

@Dhruv-Soni11
Copy link
Contributor

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 5, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR qe-approved Signifies that QE has signed off on this PR sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc. and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024 •
edited by openshift-ci bot

@shipsing: This pull request references RHDEVDOCS-5860 which is a valid jira issue.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi Srivaralakshmi merged commit b6a44f5 into openshift:gitops-docs Mar 5, 2024
1 check passed
@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.11

@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.10

@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.9

@Srivaralakshmi
Copy link
Member

/cherrypick gitops-docs-1.8

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72605

In response to this:

/cherrypick gitops-docs-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72606

In response to this:

/cherrypick gitops-docs-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 5, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72607

In response to this:

/cherrypick gitops-docs-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: #71329 failed to apply on top of branch "gitops-docs-1.8":

Applying: RHDEVDOCS-5860: Changing the text of the button
.git/rebase-apply/patch:20: trailing whitespace.
.. Enter the *Name* of the instance. By default, the *Name* is set to `example`. 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	modules/gitops-argo-cd-installation.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/gitops-argo-cd-installation.adoc
CONFLICT (content): Merge conflict in modules/gitops-argo-cd-installation.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 RHDEVDOCS-5860: Changing the text of the button
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick gitops-docs-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Srivaralakshmi Srivaralakshmi removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Mar 6, 2024
@Dhruv-Soni11 Dhruv-Soni11 mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eromanova97 eromanova97 eromanova97 left review comments

@Dhruv-Soni11 Dhruv-Soni11 Dhruv-Soni11 left review comments

@mletalie mletalie mletalie left review comments

@buildbricks buildbricks buildbricks approved these changes

@reginapizza reginapizza reginapizza approved these changes

Assignees

@mletalie mletalie

Labels
gitops jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet