Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-805: Add docs for content filtering #71434

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Feb 9, 2024

Version(s):
4.13+ (logging 5.9+)

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:
https://71434--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/performance_reliability/logging-content-filtering

QE review:

  • QE has approved this change.

@abrennan89 abrennan89 added dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 labels Feb 9, 2024
@abrennan89 abrennan89 added this to the Continuous Release milestone Feb 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2024

@abrennan89: This pull request references OBSDOCS-805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 9, 2024

🤖 Tue Mar 12 19:59:14 - Prow CI generated the docs preview:
https://71434--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2024

@abrennan89: This pull request references OBSDOCS-805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:
https://71434--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/performance_reliability/logging-content-filtering

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 force-pushed the OBSDOCS-805 branch 5 times, most recently from f5035a6 to 72e3b3a Compare February 12, 2024 17:38
@abrennan89 abrennan89 changed the title [WIP] OBSDOCS-805: Add docs for content filtering OBSDOCS-805: Add docs for content filtering Feb 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2024
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-prune-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-prune-records.adoc Outdated Show resolved Hide resolved
@abrennan89 abrennan89 force-pushed the OBSDOCS-805 branch 3 times, most recently from 44341a5 to 392e3dc Compare February 19, 2024 16:32
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-prune-records.adoc Outdated Show resolved Hide resolved
@QiaolingTang
Copy link

LGTM.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2024

@abrennan89: This pull request references OBSDOCS-805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

NOTE: Docs need to be commented out for merging until logging 5.9 release day

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:
https://71434--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/performance_reliability/logging-content-filtering

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2024

@abrennan89: This pull request references OBSDOCS-805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

NOTE: Docs need to be commented out for merging until logging 5.9 release day. Will squash commits after peer review.

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:
https://71434--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/performance_reliability/logging-content-filtering

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 11, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🤓

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-drop-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-prune-records.adoc Outdated Show resolved Hide resolved
modules/logging-content-filter-prune-records.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 11, 2024
@abrennan89 abrennan89 force-pushed the OBSDOCS-805 branch 2 times, most recently from cd3f205 to 4e939d5 Compare March 12, 2024 15:25
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 12, 2024

@abrennan89: This pull request references OBSDOCS-805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

NOTE: Docs need to be commented out for merging until logging 5.9 release day.

Issue:
https://issues.redhat.com/browse/OBSDOCS-805

Link to docs preview:
https://71434--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/performance_reliability/logging-content-filtering

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 12, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abrennan89 abrennan89 merged commit 037c9a8 into openshift:main Mar 12, 2024
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73019

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73020

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73021

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73022

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants