Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OBSDOCS-212: Add docs for http server receiver input #71780

Merged
merged 1 commit into from
Mar 1, 2024
Merged

OBSDOCS-212: Add docs for http server receiver input #71780

merged 1 commit into from
Mar 1, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Feb 16, 2024 •
edited

@abrennan89 abrennan89 added this to the Continuous Release milestone Feb 16, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2024 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-212

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 16, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 16, 2024 •
edited

🤖 Fri Mar 01 15:41:50 - Prow CI generated the docs preview:
https://71780--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2024 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-212

Link to docs preview:
https://71780--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#log-collector-http-server_cluster-logging-collector

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 force-pushed the OBSDOCS-212 branch 5 times, most recently from 203ce3b to 2002543 Compare February 21, 2024 15:05
@jlarriba
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@kalexand-rh
Copy link
Contributor

The branch/enterprise-4.16 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.15. And any PR going into main must also target the latest version branch (enterprise-4.16).

If the update in your PR does NOT apply to version 4.16 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@anpingli
Copy link

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 29, 2024 •
edited by openshift-ci bot

@abrennan89: This pull request references OBSDOCS-212 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OBSDOCS-212

Link to docs preview:
https://71780--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/cluster-logging-collector#log-collector-http-server_cluster-logging-collector

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 29, 2024
@bergerhoffer
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 29, 2024
@bergerhoffer
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 29, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 1, 2024
@abrennan89 abrennan89 force-pushed the OBSDOCS-212 branch 2 times, most recently from 59cbbba to 30b6043 Compare March 1, 2024 15:41
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 1, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 1, 2024

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • approve-rights
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@abrennan89 abrennan89 merged commit 46e063f into openshift:main Mar 1, 2024
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.12

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@abrennan89: #71780 failed to apply on top of branch "enterprise-4.12":

Applying: OBSDOCS-212: Add docs for http server receiver input
Using index info to reconstruct a base tree...
M	logging/log_collection_forwarding/cluster-logging-collector.adoc
Falling back to patching base and 3-way merge...
Auto-merging logging/log_collection_forwarding/cluster-logging-collector.adoc
CONFLICT (content): Merge conflict in logging/log_collection_forwarding/cluster-logging-collector.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OBSDOCS-212: Add docs for http server receiver input
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 1, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #72458

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #72459

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 1, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #72460

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 1, 2024
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #72461

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@jlarriba jlarriba jlarriba approved these changes

@anpingli anpingli Awaiting requested review from anpingli

Assignees

@jlarriba jlarriba

@anpingli anpingli

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @jlarriba @kalexand-rh @anpingli @bergerhoffer @openshift-cherrypick-robot