Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH#51152: document Single Node OKD #71809

Merged
merged 1 commit into from Mar 4, 2024
Merged

Conversation

mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Feb 19, 2024

Version(s):
all OKD 4 versions

Issue:
GH#51152, okd-project/planning#27
Started in #71324

Internal RH Previews:
OKD
OCP

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2024
@mburke5678 mburke5678 changed the title 71324 2 GH#51152: document Single Node OKD Feb 19, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 19, 2024

🤖 Mon Mar 04 19:07:08 - Prow CI generated the docs preview:
https://71809--ocpdocs-pr.netlify.app

@mburke5678
Copy link
Contributor Author

@vrutkovs @peterroth Made some changes since you last looked at his PR, if you are interested.

@mjpytlak FYI, some changes to the install SNO to make it compatible with OKD.

@mjpytlak
Copy link
Contributor

Thanks for the heads up @mburke5678. But I believe SNO is @johnwilkins.

ifndef::openshift-origin[]
You can install {sno} using the web-based Assisted Installer and a discovery ISO that you generate using the Assisted Installer. You can also install {sno} by using `coreos-installer` to generate the installation ISO.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 4.15 also agent-based installer is available as an installation approach. Could be worth mentioning it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andfasano if that's possible I'd add that in a separate PR. We can open a GitHub ticket for that, so that it's publicly available and the community can pick up the task. Is it viable? What do you think @mburke5678?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterroth Sounds good to me. How do we want to proceed with this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mburke5678 I can't see blockers, so if there is no veto or open task, merge this one.
The new ticket should reference this one to give context for the necessity of documenting the agent based installation.

Copy link

openshift-ci bot commented Mar 4, 2024

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72574

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72575

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@mburke5678: #71809 failed to apply on top of branch "enterprise-4.13":

Applying: GH#51152: document Single Node OKD
Using index info to reconstruct a base tree...
M	_attributes/common-attributes.adoc
M	_topic_maps/_topic_map.yml
M	installing/installing_sno/install-sno-installing-sno.adoc
M	modules/install-sno-about-installing-on-a-single-node.adoc
A	modules/install-sno-additional-requirements-for-installing-sno-on-a-cloud-provider.adoc
A	modules/install-sno-installing-sno-on-azure.adoc
A	modules/install-sno-installing-sno-on-gcp.adoc
M	modules/install-sno-monitoring-the-installation-manually.adoc
A	modules/install-sno-supported-cloud-providers-for-single-node-openshift.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): modules/install-sno-supported-cloud-providers-for-single-node-openshift.adoc deleted in HEAD and modified in GH#51152: document Single Node OKD. Version GH#51152: document Single Node OKD of modules/install-sno-supported-cloud-providers-for-single-node-openshift.adoc left in tree.
Auto-merging modules/install-sno-monitoring-the-installation-manually.adoc
CONFLICT (modify/delete): modules/install-sno-installing-sno-on-gcp.adoc deleted in HEAD and modified in GH#51152: document Single Node OKD. Version GH#51152: document Single Node OKD of modules/install-sno-installing-sno-on-gcp.adoc left in tree.
CONFLICT (modify/delete): modules/install-sno-installing-sno-on-azure.adoc deleted in HEAD and modified in GH#51152: document Single Node OKD. Version GH#51152: document Single Node OKD of modules/install-sno-installing-sno-on-azure.adoc left in tree.
CONFLICT (modify/delete): modules/install-sno-additional-requirements-for-installing-sno-on-a-cloud-provider.adoc deleted in HEAD and modified in GH#51152: document Single Node OKD. Version GH#51152: document Single Node OKD of modules/install-sno-additional-requirements-for-installing-sno-on-a-cloud-provider.adoc left in tree.
Auto-merging modules/install-sno-about-installing-on-a-single-node.adoc
Auto-merging installing/installing_sno/install-sno-installing-sno.adoc
CONFLICT (content): Merge conflict in installing/installing_sno/install-sno-installing-sno.adoc
Auto-merging _topic_maps/_topic_map.yml
Auto-merging _attributes/common-attributes.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 GH#51152: document Single Node OKD
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor

@mburke5678 Since this went into main, it has to go into 4.16 as well. Can you please cherry pick this to 4.16?

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72639

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants