-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MULTIARCH-3807] Set checkmarks for disconnected install #71869
Conversation
🤖 Tue Feb 20 14:25:51 - Prow CI generated the docs preview: https://71869--ocpdocs-pr.netlify.app |
/label peer-review-needed QE approval pending |
LGTM |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment.But mostly LGTM!
/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done
@@ -27,9 +27,8 @@ The {product-title} installation program offers the following methods for deploy | |||
|
|||
* *Interactive*: You can deploy a cluster with the web-based link:https://access.redhat.com/documentation/en-us/assisted_installer_for_openshift_container_platform[{ai-full}]. This method requires no setup for the installer, and is ideal for connected environments like {ibm-z-name}. | |||
|
|||
* *Local Agent-based*: You can deploy a cluster locally with the xref:../../installing/installing_with_agent_based_installer/preparing-to-install-with-agent-based-installer.adoc#preparing-to-install-with-agent-based-installer[Agent-based Installer]. It provides many of the benefits of the {ai-full}, but you must download and configure the Agent-based Installer first. Configuration is done with a command line interface (CLI). | |||
* *Local Agent-based*: You can deploy a cluster locally with the xref:../../installing/installing_with_agent_based_installer/preparing-to-install-with-agent-based-installer.adoc#preparing-to-install-with-agent-based-installer[Agent-based Installer]. It provides many of the benefits of the {ai-full}, but you must download and configure the Agent-based Installer first. Configuration is done with a command line interface (CLI). This approach is ideal for air-gapped or restricted networks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://redhat-documentation.github.io/supplementary-style-guide/#disconnected
"Disconnected" is the preferred term over "restricted", "air-gapped", or "offline".
I did see "air-gapped" being used for bare metal and VSphere. So feel free to ignore my comment if "air-gapped" suits best here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing I didn't know that but I like the term "disconnected" most. Will change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjpytlak @bscott-rh Is that something we should look into? I think in most of the install docs we use restricted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has been discussion over time about whether "restricted" or "disconnected" is the preferred term for this. I'm not aware of any real conclusion from those discussions.
db63b03
to
02e6f5a
Compare
02e6f5a
to
082c8a3
Compare
@SNiemann15: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label merge-review-needed |
@@ -46,7 +45,7 @@ The {product-title} installation program offers the following methods for deploy | |||
|
|||
|Restricted network {ibm-z-name} with z/VM | |||
| | |||
| | |||
|✓ | |||
|xref:../../installing/installing_ibm_z/installing-restricted-networks-ibm-z.adoc#installing-restricted-networks-ibm-z[✓] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope for the PR, but just FYI that it's hard for me (mildly red-green colorblind) to tell that these checkmarks were clickable in the rendered version.
/cherrypick enterprise-4.15 |
@adellape: new pull request created: #71912 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.15 +
Issue:
Link to docs preview: https://71869--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/preparing-to-install-on-ibm-z
QE review:
Additional information: Disconnected installations have also been tested now see comment here:
#69850 (comment)