Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MULTIARCH-3807] Set checkmarks for disconnected install #71869

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

SNiemann15
Copy link
Contributor

@SNiemann15 SNiemann15 commented Feb 20, 2024

Version(s): 4.15 +

Issue:

Link to docs preview: https://71869--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_ibm_z/preparing-to-install-on-ibm-z

QE review:

  • QE has approved this change.

Additional information: Disconnected installations have also been tested now see comment here:
#69850 (comment)

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 20, 2024

🤖 Tue Feb 20 14:25:51 - Prow CI generated the docs preview: https://71869--ocpdocs-pr.netlify.app

@SNiemann15
Copy link
Contributor Author

/label peer-review-needed

QE approval pending

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 20, 2024
@holgwolf
Copy link

LGTM

@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 20, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment.But mostly LGTM!

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

@@ -27,9 +27,8 @@ The {product-title} installation program offers the following methods for deploy

* *Interactive*: You can deploy a cluster with the web-based link:https://access.redhat.com/documentation/en-us/assisted_installer_for_openshift_container_platform[{ai-full}]. This method requires no setup for the installer, and is ideal for connected environments like {ibm-z-name}.

* *Local Agent-based*: You can deploy a cluster locally with the xref:../../installing/installing_with_agent_based_installer/preparing-to-install-with-agent-based-installer.adoc#preparing-to-install-with-agent-based-installer[Agent-based Installer]. It provides many of the benefits of the {ai-full}, but you must download and configure the Agent-based Installer first. Configuration is done with a command line interface (CLI).
* *Local Agent-based*: You can deploy a cluster locally with the xref:../../installing/installing_with_agent_based_installer/preparing-to-install-with-agent-based-installer.adoc#preparing-to-install-with-agent-based-installer[Agent-based Installer]. It provides many of the benefits of the {ai-full}, but you must download and configure the Agent-based Installer first. Configuration is done with a command line interface (CLI). This approach is ideal for air-gapped or restricted networks.
Copy link
Contributor

@xenolinux xenolinux Feb 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://redhat-documentation.github.io/supplementary-style-guide/#disconnected

"Disconnected" is the preferred term over "restricted", "air-gapped", or "offline".

I did see "air-gapped" being used for bare metal and VSphere. So feel free to ignore my comment if "air-gapped" suits best here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing I didn't know that but I like the term "disconnected" most. Will change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjpytlak @bscott-rh Is that something we should look into? I think in most of the install docs we use restricted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been discussion over time about whether "restricted" or "disconnected" is the preferred term for this. I'm not aware of any real conclusion from those discussions.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

@SNiemann15: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SNiemann15
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Feb 20, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Feb 20, 2024
@adellape adellape self-assigned this Feb 20, 2024
@@ -46,7 +45,7 @@ The {product-title} installation program offers the following methods for deploy

|Restricted network {ibm-z-name} with z/VM
|
|
|✓
|xref:../../installing/installing_ibm_z/installing-restricted-networks-ibm-z.adoc#installing-restricted-networks-ibm-z[✓]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for the PR, but just FYI that it's hard for me (mildly red-green colorblind) to tell that these checkmarks were clickable in the rendered version.

@adellape adellape added this to the Planned for 4.15 GA milestone Feb 20, 2024
@adellape adellape merged commit 4d09ea5 into openshift:main Feb 20, 2024
2 checks passed
@adellape
Copy link
Contributor

/cherrypick enterprise-4.15

@openshift-cherrypick-robot

@adellape: new pull request created: #71912

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Feb 20, 2024
@SNiemann15 SNiemann15 deleted the ibmz_agent_support branch March 1, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants