Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OADP-3525: Remove the name field from snapshotLocations spec #72144

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Feb 27, 2024

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

QE review:

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/retest

2 similar comments
@anarnold97
Copy link
Contributor Author

/retest

@anarnold97
Copy link
Contributor Author

/retest

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 28, 2024

🤖 Thu Mar 07 08:56:48 - Prow CI generated the docs preview:
https://72144--ocpdocs-pr.netlify.app

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 28, 2024
@anarnold97 anarnold97 force-pushed the OADP-3525-Remove-the-name-field-from-snapshotLocations-spec branch from b17ebc3 to 3c02c8c Compare February 28, 2024 19:35
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Version(s):

Issue:

Link to docs preview:

oadp-installing-dpa-1-2-and-earlier_installing-oadp-aws - module included elsewhere but preview will be valid for all assemblies

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 4, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 5, 2024
@amastbau
Copy link

amastbau commented Mar 7, 2024

LGTM

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2024

@anarnold97: This pull request references OADP-3525 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

JIRA

VERSIONS

  • OCP 4.12 → branch/enterprise-4.12
  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

QE review:

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label oadp

@openshift-ci openshift-ci bot added the OADP Label for all OADP PRs label Mar 7, 2024
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 7, 2024
Signed-off-by: Andy Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the OADP-3525-Remove-the-name-field-from-snapshotLocations-spec branch from 3c00cdd to 968df1e Compare March 7, 2024 08:51
Copy link

openshift-ci bot commented Mar 7, 2024

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor

dfitzmau commented Mar 7, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 7, 2024
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 7, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Mar 7, 2024
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@mburke5678 mburke5678 merged commit c30a3e9 into openshift:main Mar 7, 2024
2 checks passed
@openshift-cherrypick-robot

@mburke5678: new pull request created: #72822

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72823

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72824

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72825

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mburke5678: new pull request created: #72826

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants