New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBSDOCS-850: update CLI commands to access metrics outside the cluster for UWM #72176
OBSDOCS-850: update CLI commands to access metrics outside the cluster for UWM #72176
Conversation
@bburt-rh: This pull request references OBSDOCS-850 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
🤖 Fri Mar 01 15:41:15 - Prow CI generated the docs preview: |
@bburt-rh: This pull request references OBSDOCS-850 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b977fb9
to
2a67b9d
Compare
@simonpasquier - Can you PTAL and add comments/feedback on my changes? Thanks! |
2a67b9d
to
79e8ee1
Compare
79e8ee1
to
4171381
Compare
04c054c
to
5cb6cd7
Compare
tested like below, the doc is LGTM
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bburt-rh: This pull request references OBSDOCS-850 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@bburt-rh: This pull request references OBSDOCS-850 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label peer-review-in-progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done
/lgtm
Good job, @bburt-rh. Just had one comment/observation. |
442e216
to
61599bb
Compare
New changes are detected. LGTM label has been removed. |
@bburt-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick enterprise-4.12 |
/cherrypick enterprise-4.13 |
/cherrypick enterprise-4.14 |
/cherrypick enterprise-4.15 |
@bburt-rh: new pull request created: #72462 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #72463 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #72464 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bburt-rh: new pull request created: #72465 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.16 |
@bburt-rh: new pull request created: #72466 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.12+
Issue: https://issues.redhat.com/browse/OBSDOCS-850
Link to docs preview: https://72176--ocpdocs-pr.netlify.app/openshift-enterprise/latest/monitoring/enabling-monitoring-for-user-defined-projects#accessing-metrics-from-outside-cluster_enabling-monitoring-for-user-defined-projects
QE review:
Additional information:
This PR updates CLI commands for accessing metrics outside the cluster for user workload monitoring because the old commands no longer work in OCP 4.15+.