Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS#30133: Updates to dynamic plugin docs #72479

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

opayne1
Copy link
Contributor

@opayne1 opayne1 commented Mar 1, 2024

Updates to dynamic plugin docs

Version(s):
4.15+

Issue:
https://issues.redhat.com/browse/OCPBUGS-30133

Link to docs preview:
https://72479--ocpdocs-pr.netlify.app/openshift-enterprise/latest/web_console/dynamic-plugin/overview-dynamic-plugin

QE review:

  • QE has approved this change.

Additional information:
Provides doc updates for openshift/console#13637

@opayne1 opayne1 added this to the Continuous Release milestone Mar 1, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 1, 2024

🤖 Tue Mar 12 15:44:57 - Prow CI generated the docs preview:
https://72479--ocpdocs-pr.netlify.app

@opayne1
Copy link
Contributor Author

opayne1 commented Mar 5, 2024

@jhadvig @vojtechszocs @spadgett Added doc updates from openshift/console#13637 let me know if I missed something or misarticulated it. Thanks!

Copy link

@vojtechszocs vojtechszocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@opayne1 Just a small suggestion but feel free to change it as necessary.

web_console/dynamic-plugin/overview-dynamic-plugin.adoc Outdated Show resolved Hide resolved
web_console/dynamic-plugin/overview-dynamic-plugin.adoc Outdated Show resolved Hide resolved
@opayne1
Copy link
Contributor Author

opayne1 commented Mar 11, 2024

@yapei could you help with a QE review of this PR? Thanks! 😄

@yapei
Copy link

yapei commented Mar 12, 2024

looks good to me

@opayne1 opayne1 added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 12, 2024
@gwynnemonahan
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 12, 2024
@gwynnemonahan
Copy link
Contributor

Hey @opayne1 ,

Couple style things, but otherwise, LGTM.

Thanks!

@opayne1 opayne1 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 12, 2024
Copy link

openshift-ci bot commented Mar 12, 2024

@opayne1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor

/remove-label peer-review-in-progress

/remove-label peer-review-needed

/label peer-review-done

Copy link

openshift-ci bot commented Mar 12, 2024

@gwynnemonahan: Those labels are not set on the issue: peer-review-in-progress, peer-review-needed

In response to this:

/remove-label peer-review-in-progress

/remove-label peer-review-needed

/label peer-review-done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@opayne1 opayne1 merged commit 6d5b6b4 into openshift:main Mar 12, 2024
2 checks passed
@opayne1
Copy link
Contributor Author

opayne1 commented Mar 12, 2024

/cherrypick enterprise-4.15

@opayne1
Copy link
Contributor Author

opayne1 commented Mar 12, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@opayne1: new pull request created: #73006

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@opayne1: new pull request created: #73007

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants