-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS#30133: Updates to dynamic plugin docs #72479
Conversation
🤖 Tue Mar 12 15:44:57 - Prow CI generated the docs preview: |
@jhadvig @vojtechszocs @spadgett Added doc updates from openshift/console#13637 let me know if I missed something or misarticulated it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@opayne1 Just a small suggestion but feel free to change it as necessary.
@yapei could you help with a QE review of this PR? Thanks! 😄 |
looks good to me |
/label peer-review-in-progress |
Hey @opayne1 , Couple style things, but otherwise, LGTM. Thanks! |
@opayne1: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/remove-label peer-review-in-progress /remove-label peer-review-needed /label peer-review-done |
@gwynnemonahan: Those labels are not set on the issue: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.16 |
@opayne1: new pull request created: #73006 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@opayne1: new pull request created: #73007 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updates to dynamic plugin docs
Version(s):
4.15+
Issue:
https://issues.redhat.com/browse/OCPBUGS-30133
Link to docs preview:
https://72479--ocpdocs-pr.netlify.app/openshift-enterprise/latest/web_console/dynamic-plugin/overview-dynamic-plugin
QE review:
Additional information:
Provides doc updates for openshift/console#13637