Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30254: Updated the vSphere version for 4.14 onwards #72608

Merged
merged 1 commit into from
Mar 8, 2024
Merged

OCPBUGS-30254: Updated the vSphere version for 4.14 onwards #72608

merged 1 commit into from
Mar 8, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Mar 5, 2024 •
edited

Version(s):
4.14 +

Issue:
OCPBUGS-30254

Link to docs preview:
VMware vSphere infrastructure requirements

  • SME has approved this change.
  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-30254, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 5, 2024
@dfitzmau dfitzmau force-pushed the OCPBUGS-30254 branch 2 times, most recently from 63378e3 to 72cd2bd Compare March 5, 2024 14:05
@dfitzmau
Copy link
Contributor Author

dfitzmau commented Mar 5, 2024

/jira refresh

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-30254, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 5, 2024 •
edited

🤖 Tue Mar 05 14:59:37 - Prow CI generated the docs preview:
https://72608--ocpdocs-pr.netlify.app

@dfitzmau dfitzmau force-pushed the OCPBUGS-30254 branch 2 times, most recently from 8375277 to 3d6d994 Compare March 5, 2024 14:50
dfitzmau
dfitzmau commented Mar 5, 2024
View reviewed changes
modules/installation-vsphere-infrastructure.adoc
* Version 7.0 Update 3 or later
* Version 8.0 Update 2 or later

Both of these releases support Container Storage Interface (CSI) migration, which is enabled by default on {product-title} {product-version}.
Copy link
Contributor Author

@dfitzmau dfitzmau Mar 5, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcpowermac . OK to mention CSI migration here and its default setting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane can you take a look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfitzmau dfitzmau changed the title OCPBUGS-30254: Updated the vSphere Updarte version for 4.14 onwards OCPBUGS-30254: Updated the vSphere version for 4.14 onwards Mar 6, 2024
@jcpowermac
Copy link
Contributor

@racedo can you take a look as well. The concern was the disparity between CSI migration requirements and installation.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@racedo
Copy link

racedo commented Mar 6, 2024

/lgtm

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-30254, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):
4.14 +

Issue:
OCPBUGS-30254

Link to docs preview:
VMware vSphere infrastructure requirements

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Mar 6, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 6, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Mar 6, 2024
@mburke5678
Copy link
Contributor

/lgtm

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 6, 2024
@sgaoshang
Copy link

/lgtm cc: @duanwei33 to have a look.

@duanwei33
Copy link

LGTM
(From storage QE perspective)

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Mar 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 8, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-30254, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.14 +

Issue:
OCPBUGS-30254

Link to docs preview:
VMware vSphere infrastructure requirements

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi Srivaralakshmi added qe-approved Signifies that QE has signed off on this PR sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc. merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 8, 2024
Srivaralakshmi
Srivaralakshmi reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau Nice work! Out of scope, but you must update the content type for Module file metadata.

I will not hold the merge. However, I suggest raising a JIRA issue to address this comment. Apply this comment for all such instances in our component. Thank you!

@Srivaralakshmi Srivaralakshmi merged commit 8f9c221 into openshift:main Mar 8, 2024
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-30254 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.14 +

Issue:
OCPBUGS-30254

Link to docs preview:
VMware vSphere infrastructure requirements

  • SME has approved this change.
  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.14

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.15

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72861

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72862

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72863

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

@jcpowermac jcpowermac jcpowermac left review comments

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

Assignees

@racedo racedo

@jcpowermac jcpowermac

@mburke5678 mburke5678

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sme-review-done Service Delivery issues that have been reviewed by SRE, PMs, Engineering, QE, etc.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet