Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-23231: Added eu-es to IBM Cloud supported regions #72692

Merged
merged 1 commit into from
Mar 6, 2024
Merged

OCPBUGS-23231: Added eu-es to IBM Cloud supported regions #72692

merged 1 commit into from
Mar 6, 2024

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Mar 6, 2024 •
edited

Version(s):
4.14+

Issue:
OCPBUGS-23231

Link to docs preview:
Supported IBM Cloud regions

  • QE has approved this change.
  • SME has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 6, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-23231, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 6, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2024
@ocpdocs-previewbot
Copy link

🤖 Wed Mar 06 10:00:41 - Prow CI generated the docs preview:
https://72692--ocpdocs-pr.netlify.app

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 6, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@MayXuQQ
Copy link

MayXuQQ commented Mar 6, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 6, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-23231, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.14+

Issue:
OCPBUGS-23231

Link to docs preview:
Supported IBM Cloud regions

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Mar 6, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 6, 2024
@Srivaralakshmi Srivaralakshmi added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 6, 2024
Srivaralakshmi
Srivaralakshmi reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfitzmau Neat PR, good job! LGTM. Thank you!

@Srivaralakshmi Srivaralakshmi added lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 6, 2024
@Srivaralakshmi Srivaralakshmi added this to the Continuous Release milestone Mar 6, 2024
cjschaef
cjschaef approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@cjschaef cjschaef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 6, 2024

@cjschaef: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-23231, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Version(s):
4.14+

Issue:
OCPBUGS-23231

Link to docs preview:
Supported IBM Cloud regions

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Mar 6, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 6, 2024
@Srivaralakshmi Srivaralakshmi added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 6, 2024
@Srivaralakshmi Srivaralakshmi merged commit 8d056ab into openshift:main Mar 6, 2024
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-23231 is in an unrecognized state (Release Pending) and will not be moved to the MODIFIED state.

In response to this:

Version(s):
4.14+

Issue:
OCPBUGS-23231

Link to docs preview:
Supported IBM Cloud regions

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.14

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.15

@Srivaralakshmi
Copy link
Member

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72741

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2024
Merged
@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72742

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@Srivaralakshmi: new pull request created: #72743

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Srivaralakshmi Srivaralakshmi Srivaralakshmi left review comments

@cjschaef cjschaef cjschaef approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @MayXuQQ @Srivaralakshmi @openshift-cherrypick-robot @cjschaef