Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-30311: Remove unused IPsec config from Butane #72734

Merged
merged 1 commit into from
Mar 19, 2024
Merged

OCPBUGS-30311: Remove unused IPsec config from Butane #72734

merged 1 commit into from
Mar 19, 2024

Conversation

jab-rh
Copy link
Contributor

@jab-rh jab-rh commented Mar 6, 2024 •
edited

Version(s): 4.15+

Issue:

Link to docs preview: Configuring IPsec encryption for external traffic

QE review:

  • QE has approved this change.

Additional information:

@jab-rh jab-rh added this to the Continuous Release milestone Mar 6, 2024
@jab-rh jab-rh self-assigned this Mar 6, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 6, 2024
@openshift-ci-robot
Copy link

@jab-rh: This pull request references Jira Issue OCPBUGS-30311, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 6, 2024 •
edited

🤖 Mon Mar 18 14:19:41 - Prow CI generated the docs preview:
https://72734--ocpdocs-pr.netlify.app

@jab-rh jab-rh force-pushed the OCPBUGS-30311 branch 2 times, most recently from f84c92c to d96191c Compare March 7, 2024 17:35
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2024
huiran0826
huiran0826 reviewed Mar 14, 2024
View reviewed changes
modules/nw-ovn-ipsec-north-south-enable.adoc

.. To add the IPsec configuration, create Butane config files for the control plane and worker nodes with the following contents:
.. To create Butane config files for the control plane and worker nodes, enter the following command:
+
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For line 131, name: 99-${role}-import-certs-enable-svc-os-ext --> name: 99-${role}-import-certs, remove svc os ext related as it's only import certs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huiran0826, done!

@huiran0826
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@jab-rh
Copy link
Contributor Author

jab-rh commented Mar 19, 2024

@huiran0826 thanks!

@jab-rh jab-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 19, 2024
@ShaunaDiaz
Copy link
Contributor

/test validate-asciidoc

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 19, 2024

@jab-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 19, 2024
kcarmichael08
kcarmichael08 reviewed Mar 19, 2024
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 19, 2024
@jab-rh jab-rh merged commit e77cba3 into openshift:main Mar 19, 2024
2 checks passed
@openshift-ci-robot
Copy link

@jab-rh: Jira Issue OCPBUGS-30311 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to this:

Version(s): 4.15+

Issue:

Link to docs preview: Configuring IPsec encryption for external traffic

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jab-rh jab-rh deleted the OCPBUGS-30311 branch March 19, 2024 20:09
@jab-rh
Copy link
Contributor Author

jab-rh commented Mar 19, 2024

/cherry-pick enterprise-4.16

@jab-rh
Copy link
Contributor Author

jab-rh commented Mar 19, 2024

/cherry-pick enterprise-4.15

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2024
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #73438

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #73439

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huiran0826 huiran0826 huiran0826 left review comments

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

Assignees

@huiran0826 huiran0826

@jab-rh jab-rh

Labels
branch/enterprise-4.15 branch/enterprise-4.16 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jab-rh @openshift-ci-robot @ocpdocs-previewbot @huiran0826 @ShaunaDiaz @openshift-cherrypick-robot @kcarmichael08