Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-822: Log Collector Output Tuning #72794

Merged
merged 1 commit into from Mar 25, 2024

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Mar 7, 2024

Version(s):
4.13+ (logging 5.9+)
NOTE: Must be commented out before merging, to be uncommented at 5.9 release

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:
https://72794--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/configuring-log-forwarding#logging-delivery-tuning_configuring-log-forwarding

QE review:

  • QE has approved this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 7, 2024

@abrennan89: This pull request references OBSDOCS-822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 7, 2024

🤖 Mon Mar 25 16:28:46 - Prow CI generated the docs preview:
https://72794--ocpdocs-pr.netlify.app

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 8, 2024

@abrennan89: This pull request references OBSDOCS-822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:
https://72794--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/configuring-log-forwarding#logging-delivery-tuning_configuring-log-forwarding

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

modules/logging-delivery-tuning.adoc Outdated Show resolved Hide resolved
modules/logging-delivery-tuning.adoc Outdated Show resolved Hide resolved
modules/logging-delivery-tuning.adoc Outdated Show resolved Hide resolved
modules/logging-delivery-tuning.adoc Outdated Show resolved Hide resolved
modules/logging-delivery-tuning.adoc Outdated Show resolved Hide resolved
@abrennan89 abrennan89 force-pushed the LOG-5026 branch 2 times, most recently from 9e2cfef to cf3abd8 Compare March 13, 2024 19:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 13, 2024

@abrennan89: This pull request references OBSDOCS-822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)
NOTE: Must be commented out before merging, to be uncomment at 5.9 release

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:
https://72794--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/configuring-log-forwarding#logging-delivery-tuning_configuring-log-forwarding

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 force-pushed the LOG-5026 branch 2 times, most recently from 98fe888 to 6c7e0b0 Compare March 15, 2024 21:02
@abrennan89 abrennan89 changed the title [WIP] OBSDOCS-822: Log Collector Output Tuning OBSDOCS-822: Log Collector Output Tuning Mar 15, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@abrennan89 abrennan89 force-pushed the LOG-5026 branch 2 times, most recently from 1b60959 to 92d28c5 Compare March 18, 2024 14:36
@abrennan89 abrennan89 force-pushed the LOG-5026 branch 2 times, most recently from 04438b7 to 6b16e1f Compare March 25, 2024 15:57
Copy link

@anpingli anpingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@abrennan89 abrennan89 added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
Copy link
Contributor

@GroceryBoyJr GroceryBoyJr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GroceryBoyJr
Copy link
Contributor

/label peer-review-done
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR lgtm Indicates that a PR is ready to be merged. labels Mar 25, 2024
Copy link

openshift-ci bot commented Mar 25, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Mar 25, 2024

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@abrennan89: This pull request references OBSDOCS-822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)
NOTE: Must be commented out before merging, to be uncomment at 5.9 release

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:
https://72794--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/configuring-log-forwarding#logging-delivery-tuning_configuring-log-forwarding

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2024

@abrennan89: This pull request references OBSDOCS-822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.13+ (logging 5.9+)
NOTE: Must be commented out before merging, to be uncommented at 5.9 release

Issue:
https://issues.redhat.com/browse/OBSDOCS-822

Link to docs preview:
https://72794--ocpdocs-pr.netlify.app/openshift-enterprise/latest/logging/log_collection_forwarding/configuring-log-forwarding#logging-delivery-tuning_configuring-log-forwarding

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@abrennan89 abrennan89 merged commit eae1e41 into openshift:main Mar 25, 2024
2 checks passed
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.13

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.14

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.15

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73699

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73700

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73701

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #73702

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 dev-tools Label for all Odo/Pipelines/Helm/Developer Console/Perspective PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants